Merge pull request #1338 from pcworld/image-security-doc
Improve security-related documentation of addImage and addHtml
This commit is contained in:
commit
57ededeabf
|
|
@ -242,7 +242,7 @@ To add an image, use the ``addImage`` method to sections, headers, footers, text
|
||||||
|
|
||||||
$section->addImage($src, [$style]);
|
$section->addImage($src, [$style]);
|
||||||
|
|
||||||
- ``$src``. String path to a local image, URL of a remote image or the image data, as a string.
|
- ``$src``. String path to a local image, URL of a remote image or the image data, as a string. Warning: Do not pass user-generated strings here, as that would allow an attacker to read arbitrary files or perform server-side request forgery by passing file paths or URLs instead of image data.
|
||||||
- ``$style``. See :ref:`image-style`.
|
- ``$style``. See :ref:`image-style`.
|
||||||
|
|
||||||
Examples:
|
Examples:
|
||||||
|
|
|
||||||
|
|
@ -37,6 +37,8 @@ class Html
|
||||||
* Add HTML parts.
|
* Add HTML parts.
|
||||||
*
|
*
|
||||||
* Note: $stylesheet parameter is removed to avoid PHPMD error for unused parameter
|
* Note: $stylesheet parameter is removed to avoid PHPMD error for unused parameter
|
||||||
|
* Warning: Do not pass user-generated HTML here, as that would allow an attacker to read arbitrary
|
||||||
|
* files or perform server-side request forgery by passing local file paths or URLs in <img>.
|
||||||
*
|
*
|
||||||
* @param \PhpOffice\PhpWord\Element\AbstractContainer $element Where the parts need to be added
|
* @param \PhpOffice\PhpWord\Element\AbstractContainer $element Where the parts need to be added
|
||||||
* @param string $html The code to parse
|
* @param string $html The code to parse
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue