From afed126ab1cdc8c8e9b4c301d355fb458a79170b Mon Sep 17 00:00:00 2001 From: dfsd534 Date: Sat, 10 Apr 2021 11:49:32 +0800 Subject: [PATCH 1/2] update --- src/PhpWord/Writer/Word2007/Part/Chart.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/PhpWord/Writer/Word2007/Part/Chart.php b/src/PhpWord/Writer/Word2007/Part/Chart.php index e3b56eaa..b01dd794 100644 --- a/src/PhpWord/Writer/Word2007/Part/Chart.php +++ b/src/PhpWord/Writer/Word2007/Part/Chart.php @@ -188,7 +188,9 @@ class Chart extends AbstractPart // Series $this->writeSeries($xmlWriter, isset($this->options['scatter'])); - $xmlWriter->writeElementBlock('c:overlap', 'val', '100'); + if(!isset($this->options['grouping']) OR $this->options['grouping'] != 'clustered'){ + $xmlWriter->writeElementBlock('c:overlap', 'val', '100'); + } // Axes if (isset($this->options['axes'])) { From 0692a55fa4312285ff867e080e25d2a3ddaa9936 Mon Sep 17 00:00:00 2001 From: DE TROOSTEMBERGH Antoine Date: Thu, 15 Apr 2021 21:19:38 +0200 Subject: [PATCH 2/2] checkstyle fixes --- src/PhpWord/Writer/Word2007/Part/Chart.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/PhpWord/Writer/Word2007/Part/Chart.php b/src/PhpWord/Writer/Word2007/Part/Chart.php index b01dd794..5e9043ca 100644 --- a/src/PhpWord/Writer/Word2007/Part/Chart.php +++ b/src/PhpWord/Writer/Word2007/Part/Chart.php @@ -188,7 +188,8 @@ class Chart extends AbstractPart // Series $this->writeSeries($xmlWriter, isset($this->options['scatter'])); - if(!isset($this->options['grouping']) OR $this->options['grouping'] != 'clustered'){ + // don't overlap if grouping is 'clustered' + if (!isset($this->options['grouping']) || $this->options['grouping'] != 'clustered') { $xmlWriter->writeElementBlock('c:overlap', 'val', '100'); }