Merge pull request #1513 from carusogabriel/phpunit

Use dedicated PHPUnit assertions
This commit is contained in:
troosan 2018-11-30 22:58:01 +01:00 committed by GitHub
commit d9165f00fa
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 7 deletions

View File

@ -73,8 +73,8 @@ class ElementTest extends \PHPUnit\Framework\TestCase
$dom = $this->getAsHTML($phpWord); $dom = $this->getAsHTML($phpWord);
$xpath = new \DOMXPath($dom); $xpath = new \DOMXPath($dom);
$this->assertTrue($xpath->query('/html/body/p[1]/ins')->length == 1); $this->assertEquals(1, $xpath->query('/html/body/p[1]/ins')->length);
$this->assertTrue($xpath->query('/html/body/p[2]/del')->length == 1); $this->assertEquals(1, $xpath->query('/html/body/p[2]/del')->length);
} }
/** /**
@ -97,9 +97,9 @@ class ElementTest extends \PHPUnit\Framework\TestCase
$dom = $this->getAsHTML($phpWord); $dom = $this->getAsHTML($phpWord);
$xpath = new \DOMXPath($dom); $xpath = new \DOMXPath($dom);
$this->assertTrue($xpath->query('/html/body/table/tr[1]/td')->length == 1); $this->assertEquals(1, $xpath->query('/html/body/table/tr[1]/td')->length);
$this->assertEquals('2', $xpath->query('/html/body/table/tr/td[1]')->item(0)->attributes->getNamedItem('colspan')->textContent); $this->assertEquals('2', $xpath->query('/html/body/table/tr/td[1]')->item(0)->attributes->getNamedItem('colspan')->textContent);
$this->assertTrue($xpath->query('/html/body/table/tr[2]/td')->length == 2); $this->assertEquals(2, $xpath->query('/html/body/table/tr[2]/td')->length);
} }
/** /**
@ -126,9 +126,9 @@ class ElementTest extends \PHPUnit\Framework\TestCase
$dom = $this->getAsHTML($phpWord); $dom = $this->getAsHTML($phpWord);
$xpath = new \DOMXPath($dom); $xpath = new \DOMXPath($dom);
$this->assertTrue($xpath->query('/html/body/table/tr[1]/td')->length == 2); $this->assertEquals(2, $xpath->query('/html/body/table/tr[1]/td')->length);
$this->assertEquals('3', $xpath->query('/html/body/table/tr[1]/td[1]')->item(0)->attributes->getNamedItem('rowspan')->textContent); $this->assertEquals('3', $xpath->query('/html/body/table/tr[1]/td[1]')->item(0)->attributes->getNamedItem('rowspan')->textContent);
$this->assertTrue($xpath->query('/html/body/table/tr[2]/td')->length == 1); $this->assertEquals(1, $xpath->query('/html/body/table/tr[2]/td')->length);
} }
private function getAsHTML(PhpWord $phpWord) private function getAsHTML(PhpWord $phpWord)
@ -155,7 +155,7 @@ class ElementTest extends \PHPUnit\Framework\TestCase
$htmlWriter = new HTML($phpWord); $htmlWriter = new HTML($phpWord);
$content = $htmlWriter->getContent(); $content = $htmlWriter->getContent();
$this->assertTrue(strpos($content, $expected) !== false); $this->assertContains($expected, $content);
} }
/** /**