Clientbase
/
PhpSpreadsheet
mirror of https://github.com/basemaster/PhpSpreadsheet.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Pdf Writer strtoupper() fix (#1629) 

* _setPageSize's strtoupper()  on array argument

PhpSpreadsheet/Writer/Pdf.php Class defines a protected static mixed array called $paperSizes, this array contains string values along with array values. 'strtoupper() expects parameter 1 to be string, array given' error happens due to array passed to $paperSize variable from that $paperSizes mixed array on the Mpdf Class where Pdf extends

Examples of cases, when a 'Letter' paper size is chosen, then no problem occurs since the index in that value for the array is a string value, but when 'Tabloid' paper size is chosen the value in the index for that paper size is an array, that's when the strtoupper() error happens

* _setPageSize's strtoupper() on array argument

PhpSpreadsheet/Writer/Pdf.php Class defines a protected static mixed array called $paperSizes, this array contains string values along with array values. 'strtoupper() expects parameter 1 to be string, array given' error happens due to array passed to $paperSize variable from that $paperSizes mixed array on the Dompdf Class where Pdf extends

Examples of cases; when a 'Letter' paper size is chosen, then no problem occurs since the index in the array for that value a string, but when 'Tabloid' paper size is chosen the value in the index for that paper size is an array, that's when the strtoupper() error happens.
This commit is contained in:
adancabanas 2021-02-28 09:58:57 -07:00 committed by GitHub
parent 1d6f36d8df
commit 0715b63f11
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/PhpSpreadsheet/Writer/Pdf/Dompdf.php
View File

@ -59,7 +59,7 @@ class Dompdf extends Pdf
// Create PDF // Create PDF
$pdf = $this->createExternalWriterInstance(); $pdf = $this->createExternalWriterInstance();
$pdf->setPaper(strtolower($paperSize), $orientation); $pdf->setPaper($paperSize, $orientation);
$pdf->loadHtml($this->generateHTMLAll()); $pdf->loadHtml($this->generateHTMLAll());
$pdf->render(); $pdf->render();

2
src/PhpSpreadsheet/Writer/Pdf/Mpdf.php
View File

@ -64,7 +64,7 @@ class Mpdf extends Pdf
$config = ['tempDir' => $this->tempDir . '/mpdf']; $config = ['tempDir' => $this->tempDir . '/mpdf'];
$pdf = $this->createExternalWriterInstance($config); $pdf = $this->createExternalWriterInstance($config);
$ortmp = $orientation; $ortmp = $orientation;
$pdf->_setPageSize(strtoupper($paperSize), $ortmp); $pdf->_setPageSize($paperSize, $ortmp);
$pdf->DefOrientation = $orientation; $pdf->DefOrientation = $orientation;
$pdf->AddPageByArray([ $pdf->AddPageByArray([
'orientation' => $orientation, 'orientation' => $orientation,