Clientbase
/
PhpSpreadsheet
mirror of https://github.com/basemaster/PhpSpreadsheet.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Change removeComment to use CellCoordinate

This commit is contained in:
Dams 2022-06-09 09:08:02 +02:00 committed by GitHub
parent 391e6308d7
commit 13437384af
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 18 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
src/PhpSpreadsheet/Worksheet/Worksheet.php
View File

@ -2581,22 +2581,31 @@ class Worksheet implements IComparable
return $this; return $this;
} }
/** /**
* Remove comment. * Remove comment from cell.
* *
* @param int $columnIndex Numeric column coordinate of the cell * @param array<int>|CellAddress|string $cellCoordinate Coordinate of the cell as a string, eg: 'C5';
* @param int $row Numeric row coordinate of the cell * or as an array of [$columnIndex, $row] (e.g. [3, 5]), or a CellAddress object.
* *
* @return Comment
*/ */
public function removeCommentByColumnAndRow($columnIndex, $row) public function removeComment($cellCoordinate)
{ {
$pCellCoordinate = strtoupper(Coordinate::stringFromColumnIndex($columnIndex) . $row); $cellAddress = Functions::trimSheetFromCellReference(Validations::validateCellAddress($cellCoordinate));
if(isset($this->comments[$pCellCoordinate])) {
unset($this->comments[$pCellCoordinate]); if (Coordinate::coordinateIsRange($cellAddress)) {
throw new Exception('Cell coordinate string can not be a range of cells.');
} elseif (strpos($cellAddress, '$') !== false) {
throw new Exception('Cell coordinate string must not be absolute.');
} elseif ($cellAddress == '') {
throw new Exception('Cell coordinate can not be zero-length string.');
} }
} // Check if we have a comment for this cell and delete it
if (isset($this->comments[$cellAddress])) {
unset($this->comments[$cellAddress]);
}
}
/** /**
* Get comment for cell. * Get comment for cell.