From 3c4a51acb5b50a2d04817db03d063d34b8a5302f Mon Sep 17 00:00:00 2001 From: aswinkumar863 Date: Sun, 17 Apr 2022 17:43:32 +0530 Subject: [PATCH] Minor refactoring work testColumnInRange method renamed to isColumnInRange --- src/PhpSpreadsheet/Worksheet/Table.php | 10 +++++----- src/PhpSpreadsheet/Worksheet/Table/Column.php | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/PhpSpreadsheet/Worksheet/Table.php b/src/PhpSpreadsheet/Worksheet/Table.php index cfb8edfd..ee664aa6 100644 --- a/src/PhpSpreadsheet/Worksheet/Table.php +++ b/src/PhpSpreadsheet/Worksheet/Table.php @@ -272,7 +272,7 @@ class Table * * @return int The column offset within the table range */ - public function testColumnInRange($column) + public function isColumnInRange($column) { if (empty($this->range)) { throw new PhpSpreadsheetException('No table range is defined.'); @@ -296,7 +296,7 @@ class Table */ public function getColumnOffset($column) { - return $this->testColumnInRange($column); + return $this->isColumnInRange($column); } /** @@ -308,7 +308,7 @@ class Table */ public function getColumn($column) { - $this->testColumnInRange($column); + $this->isColumnInRange($column); if (!isset($this->columns[$column])) { $this->columns[$column] = new Table\Column($column, $this); @@ -349,7 +349,7 @@ class Table } else { throw new PhpSpreadsheetException('Column is not within the table range.'); } - $this->testColumnInRange($column); + $this->isColumnInRange($column); if (is_string($columnObjectOrString)) { $this->columns[$columnObjectOrString] = new Table\Column($columnObjectOrString, $this); @@ -371,7 +371,7 @@ class Table */ public function clearColumn($column) { - $this->testColumnInRange($column); + $this->isColumnInRange($column); if (isset($this->columns[$column])) { unset($this->columns[$column]); diff --git a/src/PhpSpreadsheet/Worksheet/Table/Column.php b/src/PhpSpreadsheet/Worksheet/Table/Column.php index 06284c67..385ba171 100644 --- a/src/PhpSpreadsheet/Worksheet/Table/Column.php +++ b/src/PhpSpreadsheet/Worksheet/Table/Column.php @@ -89,7 +89,7 @@ class Column // Uppercase coordinate $column = strtoupper($column); if ($this->table !== null) { - $this->table->testColumnInRange($column); + $this->table->isColumnInRange($column); } $this->columnIndex = $column;