Clientbase
/
PhpSpreadsheet
mirror of https://github.com/basemaster/PhpSpreadsheet.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2915 from PHPOffice/Performance-Refresh-Row/Column-Dimensions 

Minor memory improvement
This commit is contained in:
Mark Baker 2022-06-30 17:18:37 +02:00 committed by GitHub
parent 5d5e550342 01d2d541c5
commit 5b74d1ffca
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/PhpSpreadsheet/ReferenceHelper.php
View File

@ -316,6 +316,7 @@ class ReferenceHelper
$objColumnDimension->setColumnIndex($newReference); $objColumnDimension->setColumnIndex($newReference);
} }
} }
$worksheet->refreshColumnDimensions(); $worksheet->refreshColumnDimensions();
} }
} }
@ -339,6 +340,7 @@ class ReferenceHelper
$objRowDimension->setRowIndex($newRoweference); $objRowDimension->setRowIndex($newRoweference);
} }
} }
$worksheet->refreshRowDimensions(); $worksheet->refreshRowDimensions();
$copyDimension = $worksheet->getRowDimension($beforeRow - 1); $copyDimension = $worksheet->getRowDimension($beforeRow - 1);

8
src/PhpSpreadsheet/Worksheet/Worksheet.php
View File

@ -658,10 +658,8 @@ class Worksheet implements IComparable
*/ */
public function refreshColumnDimensions() public function refreshColumnDimensions()
{ {
$currentColumnDimensions = $this->getColumnDimensions();
$newColumnDimensions = []; $newColumnDimensions = [];
foreach ($this->getColumnDimensions() as $objColumnDimension) {
foreach ($currentColumnDimensions as $objColumnDimension) {
$newColumnDimensions[$objColumnDimension->getColumnIndex()] = $objColumnDimension; $newColumnDimensions[$objColumnDimension->getColumnIndex()] = $objColumnDimension;
} }
@ -677,10 +675,8 @@ class Worksheet implements IComparable
*/ */
public function refreshRowDimensions() public function refreshRowDimensions()
{ {
$currentRowDimensions = $this->getRowDimensions();
$newRowDimensions = []; $newRowDimensions = [];
foreach ($this->getRowDimensions() as $objRowDimension) {
foreach ($currentRowDimensions as $objRowDimension) {
$newRowDimensions[$objRowDimension->getRowIndex()] = $objRowDimension; $newRowDimensions[$objRowDimension->getRowIndex()] = $objRowDimension;
} }