Clientbase
/
PhpSpreadsheet
mirror of https://github.com/basemaster/PhpSpreadsheet.git
3
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Unit test for RichText object

This commit is contained in:
MarkBaker 2021-06-03 20:03:53 +02:00 committed by Mark Baker
parent 883115a079
commit 8cea3a94df
2 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/PhpSpreadsheet/Cell/StringValueBinder.php
View File

@ -89,9 +89,6 @@ class StringValueBinder implements IValueBinder
$cell->setValueExplicit((string)$value, DataType::TYPE_INLINE); $cell->setValueExplicit((string)$value, DataType::TYPE_INLINE);
return true; return true;
} else {
// Attempt to cast any unexpected objects to string
$value = (string) $value;
} }
} }

14
tests/PhpSpreadsheetTests/Cell/StringValueBinderTest.php
View File

@ -6,7 +6,9 @@ use DateTime;
use DateTimeZone; use DateTimeZone;
use PhpOffice\PhpSpreadsheet\Cell\Cell; use PhpOffice\PhpSpreadsheet\Cell\Cell;
use PhpOffice\PhpSpreadsheet\Cell\DataType; use PhpOffice\PhpSpreadsheet\Cell\DataType;
use PhpOffice\PhpSpreadsheet\Cell\DefaultValueBinder;
use PhpOffice\PhpSpreadsheet\Cell\StringValueBinder; use PhpOffice\PhpSpreadsheet\Cell\StringValueBinder;
use PhpOffice\PhpSpreadsheet\RichText\RichText;
use PhpOffice\PhpSpreadsheet\Style\Style; use PhpOffice\PhpSpreadsheet\Style\Style;
use PHPUnit\Framework\MockObject\MockObject; use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\TestCase; use PHPUnit\Framework\TestCase;
@ -245,4 +247,16 @@ class StringValueBinderTest extends TestCase
[1.23e-24, 1.23E-24, DataType::TYPE_NUMERIC], [1.23e-24, 1.23E-24, DataType::TYPE_NUMERIC],
]; ];
} }
public function testStringValueBinderForRichTextObject(): void
{
$objRichText = new RichText();
$objRichText->createText('Hello World');
$cellStub = $this->createCellStub($objRichText, DataType::TYPE_INLINE);
$binder = new StringValueBinder();
$binder->setConversionForAllValueTypes(false);
$binder->bindValue($cellStub, $objRichText);
}
} }