Clientbase
/
PhpSpreadsheet
mirror of https://github.com/basemaster/PhpSpreadsheet.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Disable URLImageTest (#2843) 

This test has always been problematic in that it depends on an external site not under the control of PhpSpreadsheet, and can therefore break at any time. As it has done this morning. Disable it until a better test is available.
This commit is contained in:
oleibman 2022-05-21 06:46:02 -07:00 committed by GitHub
parent b8957205e1
commit 9d36e442e9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tests/PhpSpreadsheetTests/Reader/Xlsx/URLImageTest.php
View File

@ -11,9 +11,12 @@ class URLImageTest extends TestCase
{
public function testURLImageSource(): void
{
if (getenv('SKIP_URL_IMAGE_TEST') === '1') {
self::markTestSkipped('Skipped due to setting of environment variable');
if (getenv('RUN_URL_IMAGE_TEST') !== '1') {
self::markTestSkipped('Skipped due to no longer bein able to access external URL');
}
//if (getenv('SKIP_URL_IMAGE_TEST') === '1') {
// self::markTestSkipped('Skipped due to setting of environment variable');
//}
$filename = realpath(__DIR__ . '/../../../data/Reader/XLSX/urlImage.xlsx');
self::assertNotFalse($filename);
$reader = IOFactory::createReader('Xlsx');