3 New Phpstan 1.4.5 Changes (#2559)

* 3 New Phpstan 1.4.5 Changes

It requires evidence that second parameter to array_chunk > 0.

* Try to Get Github Going

Everything showed "waiting for status to be reported" after several hours. Let's see if a comment change kicks things off properly.

src/PhpSpreadsheet/Calculation/MathTrig/MatrixFunctions.php

@@ -12,7 +12,7 @@ use PhpOffice\PhpSpreadsheet\Calculation\Functions;
 class MatrixFunctions
 {
     /**
-     * Convert parameter to matrix.
+     * Convert parameter to Matrix.
      *
      * @param mixed $matrixValues A matrix of values
      */
@@ -73,13 +73,13 @@ class MatrixFunctions
         if ($step === 0) {
             return array_chunk(
                 array_fill(0, $rows * $columns, $start),
-                $columns
+                max($columns, 1)
             );
         }
 
         return array_chunk(
             range($start, $start + (($rows * $columns - 1) * $step), $step),
-            $columns
+            max($columns, 1)
         );
     }
 

src/PhpSpreadsheet/Calculation/MathTrig/Random.php

@@ -82,7 +82,7 @@ class Random
                 },
                 array_fill(0, $rows * $columns, $min)
             ),
-            $columns
+            max($columns, 1)
         );
     }
 }