Clientbase
/
PhpSpreadsheet
mirror of https://github.com/basemaster/PhpSpreadsheet.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

#984 fix php-cs-fixer warnings

This commit is contained in:
xandros15 2021-05-11 12:44:40 +02:00
parent d0f76fd3ba
commit bb11378fca
3 changed files with 10 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/PhpSpreadsheet/Style/Conditional.php
View File

@ -314,11 +314,7 @@ class Conditional implements IComparable
} }
/** /**
* Verify if param is valid condition type * Verify if param is valid condition type.
*
* @param string $type
*
* @return bool
*/ */
public static function isValidConditionType(string $type): bool public static function isValidConditionType(string $type): bool
{ {

13
tests/PhpSpreadsheetTests/Reader/Xlsx/ConditionalTest.php
View File

@ -8,9 +8,8 @@ use PhpOffice\PhpSpreadsheetTests\Functional\AbstractFunctional;
class ConditionalTest extends AbstractFunctional class ConditionalTest extends AbstractFunctional
{ {
/** /**
* Test check if conditional style with type 'notContainsText' works on xlsx * Test check if conditional style with type 'notContainsText' works on xlsx.
*/ */
public function testConditionalNotContainsText(): void public function testConditionalNotContainsText(): void
{ {
@ -20,12 +19,12 @@ class ConditionalTest extends AbstractFunctional
$worksheet = $spreadsheet->getActiveSheet(); $worksheet = $spreadsheet->getActiveSheet();
$styles = $worksheet->getConditionalStyles('A1:A5'); $styles = $worksheet->getConditionalStyles('A1:A5');
$this->assertCount(1, $styles); self::assertCount(1, $styles);
/** @var $notContainsTextStyle Conditional */ /** @var Conditional $notContainsTextStyle */
$notContainsTextStyle = $styles[0]; $notContainsTextStyle = $styles[0];
$this->assertEquals('A', $notContainsTextStyle->getText()); self::assertEquals('A', $notContainsTextStyle->getText());
$this->assertEquals(Conditional::CONDITION_NOTCONTAINSTEXT, $notContainsTextStyle->getConditionType()); self::assertEquals(Conditional::CONDITION_NOTCONTAINSTEXT, $notContainsTextStyle->getConditionType());
$this->assertEquals(Conditional::OPERATOR_NOTCONTAINS, $notContainsTextStyle->getOperatorType()); self::assertEquals(Conditional::OPERATOR_NOTCONTAINS, $notContainsTextStyle->getOperatorType());
} }
} }

6
tests/PhpSpreadsheetTests/Writer/Xlsx/ConditionalTest.php
View File

@ -30,7 +30,7 @@ class ConditionalTest extends AbstractFunctional
} }
/** /**
* Test check if conditional style with type 'notContainsText' works on xlsx * Test check if conditional style with type 'notContainsText' works on xlsx.
*/ */
public function testConditionalNotContainsText(): void public function testConditionalNotContainsText(): void
{ {
@ -40,7 +40,7 @@ class ConditionalTest extends AbstractFunctional
$condition = new Conditional(); $condition = new Conditional();
$condition->setConditionType(Conditional::CONDITION_NOTCONTAINSTEXT); $condition->setConditionType(Conditional::CONDITION_NOTCONTAINSTEXT);
$condition->setOperatorType(Conditional::OPERATOR_NOTCONTAINS); $condition->setOperatorType(Conditional::OPERATOR_NOTCONTAINS);
$condition->setText("C"); $condition->setText('C');
$condition->getStyle()->applyFromArray([ $condition->getStyle()->applyFromArray([
'fill' => [ 'fill' => [
'color' => ['argb' => 'FFFFC000'], 'color' => ['argb' => 'FFFFC000'],
@ -55,6 +55,6 @@ class ConditionalTest extends AbstractFunctional
$needle = <<<xml $needle = <<<xml
<conditionalFormatting sqref="A1:A5"><cfRule type="notContainsText" dxfId="" priority="1" operator="notContains" text="C"><formula>ISERROR(SEARCH(&quot;C&quot;,A1:A5))</formula></cfRule></conditionalFormatting> <conditionalFormatting sqref="A1:A5"><cfRule type="notContainsText" dxfId="" priority="1" operator="notContains" text="C"><formula>ISERROR(SEARCH(&quot;C&quot;,A1:A5))</formula></cfRule></conditionalFormatting>
xml; xml;
$this->assertStringContainsString($needle, $data); self::assertStringContainsString($needle, $data);
} }
} }