From eb34e02085acbba673a7a64f4226d3c475410ea1 Mon Sep 17 00:00:00 2001
From: oleibman <10341515+oleibman@users.noreply.github.com>
Date: Sun, 8 May 2022 11:48:04 -0700
Subject: [PATCH] Restore Tcpdf/Dompdf to Samples in Test Suite (#2814)

They were dropped because they weren't ready for PHP8 when we were. They are ready now.
---
 .../PhpSpreadsheetTests/Helper/SampleTest.php | 19 ++-----------------
 1 file changed, 2 insertions(+), 17 deletions(-)

diff --git a/tests/PhpSpreadsheetTests/Helper/SampleTest.php b/tests/PhpSpreadsheetTests/Helper/SampleTest.php
index a86d8405..50a650f8 100644
--- a/tests/PhpSpreadsheetTests/Helper/SampleTest.php
+++ b/tests/PhpSpreadsheetTests/Helper/SampleTest.php
@@ -11,10 +11,8 @@ class SampleTest extends TestCase
      * @runInSeparateProcess
      * @preserveGlobalState disabled
      * @dataProvider providerSample
-     *
-     * @param mixed $sample
      */
-    public function testSample($sample): void
+    public function testSample(string $sample): void
     {
         // Suppress output to console
         $this->setOutputCallback(function (): void {
@@ -32,18 +30,8 @@ class SampleTest extends TestCase
             'Chart/32_Chart_read_write_HTML.php', // idem
             'Chart/35_Chart_render.php', // idem
         ];
-        // TCPDF and DomPDF libraries don't support PHP8 yet
-        if (\PHP_VERSION_ID >= 80000) {
-            $skipped = array_merge(
-                $skipped,
-                [
-                    'Pdf/21_Pdf_Domdf.php',
-                    'Pdf/21_Pdf_TCPDF.php',
-                ]
-            );
-        }
 
-        // Unfortunately some tests are too long be ran with code-coverage
+        // Unfortunately some tests are too long to run with code-coverage
         // analysis on GitHub Actions, so we need to exclude them
         global $argv;
         if (in_array('--coverage-clover', $argv)) {
@@ -58,9 +46,6 @@ class SampleTest extends TestCase
         $result = [];
         foreach ($helper->getSamples() as $samples) {
             foreach ($samples as $sample) {
-//                if (array_pop(explode('/', $sample)) !== 'DGET.php') {
-//                    continue;
-//                }
                 if (!in_array($sample, $skipped)) {
                     $file = 'samples/' . $sample;
                     $result[$sample] = [$file];