Another Undefined Index in Xls Reader (#2470)

Fix #2463. These continue to dribble in regularly.
This commit is contained in:
oleibman 2021-12-31 13:43:59 -08:00 committed by GitHub
parent 5d1ab39def
commit f24dcc7911
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 21 additions and 1 deletions

View File

@ -6941,7 +6941,7 @@ class Xls extends BaseReader
// offset: 1; size: 2; one-based index to definedname record
$definedNameIndex = self::getUInt2d($formulaData, 1) - 1;
// offset: 2; size: 2; not used
$data = $this->definedname[$definedNameIndex]['name'];
$data = $this->definedname[$definedNameIndex]['name'] ?? '';
break;
case 0x24: // single cell reference e.g. A5

View File

@ -0,0 +1,20 @@
<?php
namespace PhpOffice\PhpSpreadsheetTests\Reader\Xls;
use PhpOffice\PhpSpreadsheet\Reader\Xls;
use PHPUnit\Framework\TestCase;
class Issue2463Test extends TestCase
{
public function testNoUnknownIndexNotice(): void
{
// Unknown index notice when loading
$filename = 'tests/data/Reader/XLS/issue.2463.xls';
$reader = new Xls();
$spreadsheet = $reader->load($filename);
$sheet = $spreadsheet->getActiveSheet();
self::assertSame('bol.com bestellingen', $sheet->getTitle());
$spreadsheet->disconnectWorksheets();
}
}

Binary file not shown.