PhpSpreadsheet

Commit Graph

Author	SHA1	Message	Date
oleibman	adbda63912	Phpstan and Xlsx Reader (#3043 ) Eliminate most Phpstan messages in Xlsx Reader. In combination with similar changes to Xlsx Writer, baseline will shrink to just over 3,000 lines.	2022-09-04 10:43:31 -07:00
oleibman	eb76c3c0ff	Code Coverage >90% (#2973 ) No source code changes, just additional tests. FormulaParser appears unused, replaced by newer code in Calculation. However, it's a public interface, so probably shouldn't be deleted without first deprecating it. I have no strong feelings about whether that should happen. However, as long as it's part of the package, we may as well have some formal unit tests for it.	2022-08-06 17:56:30 -07:00

Author

SHA1

Message

Date

oleibman

adbda63912

Phpstan and Xlsx Reader (#3043 )

Eliminate most Phpstan messages in Xlsx Reader. In combination with similar changes to Xlsx Writer, baseline will shrink to just over 3,000 lines.

2022-09-04 10:43:31 -07:00

oleibman

eb76c3c0ff

Code Coverage >90% (#2973 )

No source code changes, just additional tests. FormulaParser appears unused, replaced by newer code in Calculation. However, it's a public interface, so probably shouldn't be deleted without first deprecating it. I have no strong feelings about whether that should happen. However, as long as it's part of the package, we may as well have some formal unit tests for it.

2022-08-06 17:56:30 -07:00

2 Commits