198878b347
Add unit tests for ChartSheet reading
2022-05-16 13:30:30 +02:00
34dd0a929e
Read ChartSheets with the Xlsx Reader if includeCharts is enabled; although we're reading it as a normal worksheet that simply contains a chart at cell A1, xOffset 0, yOffset 0, with no data
...
And Handle ChartSheets in the Xlsx Writer
2022-05-16 13:30:30 +02:00
092ddbd542
Remove spurious (and out-of-date) text file from source
2022-05-13 10:32:49 +02:00
5352dbed49
Changelog
2022-05-13 08:49:59 +02:00
ce940a35e9
Merge pull request #2827 from PHPOffice/Issue-2826_Xls-Reader-Converting-Named-Ranges-to-Relative
...
Fix issue with Xls Reader converting all named ranges from absolute to relative
2022-05-12 12:52:26 +02:00
fd44f47f62
Fix issue with Xls Reader converting all named ranges from absolute to relative
2022-05-12 12:47:18 +02:00
54d82cd023
Merge pull request #2825 from PHPOffice/Column-Autofit-Indentation
...
Column autofit indentation
2022-05-11 20:13:04 +02:00
ffd900b6df
composer fix
2022-05-11 20:02:58 +02:00
dbcb84bd4d
phpstan fix
2022-05-11 19:54:16 +02:00
4a4078f38f
Merge branch 'master' into Column-Autofit-Indentation
2022-05-11 19:00:43 +02:00
a352856485
Merge pull request #2824 from PHPOffice/CalcEngine-Function-Return-Type-CellReference
...
Calc engine function return type cell reference
2022-05-11 18:59:13 +02:00
dd3ed498e9
Trying to rationalise phpstan between local and CI
2022-05-11 18:48:05 +02:00
65053d711c
Assertion updates
2022-05-11 16:06:44 +02:00
153a3a6af6
Fix for null value passed to extractSheetTitle()
2022-05-11 16:06:19 +02:00
bb96542b64
Autofit adjustment for indent
2022-05-11 12:33:01 +02:00
070bc68514
Html Reader Converting Cell Containing 0 to Null String ( #2813 )
...
Fix #2810 . Repairing some Phpstan diagnostics, used `?:` rather than `??` in a few places.
2 different Html modules are affected. Also, Ods Reader, but its problem is with sheet title rather than cell contents. And, as it turns out, Ods Reader was already not handling sheets with a title of `0` correctly - it made a truthy test before setting sheet title. That is now changed to truthy or numeric. Other readers are not susceptible to this problem. Tests are added.
2022-05-10 07:33:45 -07:00
b0bfdde164
Cleanup After Phpstan Upgrade ( #2800 )
...
After Phpstan 1.6.3 upgrade, clean up some new problems that will show up if it runs under Php 8+.
2022-05-10 07:20:22 -07:00
4d5a4824c4
Merge pull request #2820 from PHPOffice/Performance-Coordinates-2
...
Performance tweaks to calculating column string from index
2022-05-10 13:57:28 +02:00
55f03a5d38
Performance tweaks to calculating column string from index
2022-05-10 13:28:18 +02:00
32efe0ee45
Merge pull request #2819 from PHPOffice/Performance-Coordinates
...
Performance tweaks to calculating column string from index
2022-05-10 12:51:14 +02:00
a0ad01e91d
Performance tweaks to calculating column string from index
2022-05-10 12:33:43 +02:00
05d08fe787
Merge pull request #2818 from PHPOffice/Performance-Minor-Tweaks
...
Performance tweaks to cell address validation
2022-05-09 20:23:03 +02:00
677054dd0a
Performance tweaks to cell address validation
2022-05-09 15:40:17 +02:00
eb34e02085
Restore Tcpdf/Dompdf to Samples in Test Suite ( #2814 )
...
They were dropped because they weren't ready for PHP8 when we were. They are ready now.
2022-05-08 11:48:04 -07:00
35530502d2
Allow Csv Reader to Treat String as Contents of File ( #2792 )
...
See #1285 , which went stale and was closed, but recently received some positive feeback. It seems easy to implement, and the only other plaintext file format, Html, allows loading from a string. Those two reasons combined suggest that we should do it.
2022-05-07 08:24:53 -07:00
a32861a0a0
Copy from Xls(x) to Html/Pdf Loses Drawings ( #2788 )
...
Drawings in an Xlsx file are stored in such a way that Php can read their contents using the `zip:` protocol. This does not, however, work when the file is read by PhpSpreadsheet and then saved as Html or Pdf, since the browser will not recognize that protocol even if the file is available. Such drawings need to be saved in the html as embedded images in order for the copy to display them properly. This is true even when the writer is set to not embed images (default).
An additional problem arises when an Html file with an embedded image is read, because `Worksheet\Drawing::setPath` attempts to validate the path, which it cannot do for the `data:image` Url which embedded images use.
And yet another problem. Writer/Html writes out a MemoryDrawing as a png using the imagepng function; but then declares it as jpeg in the Html. This is now corrected.
And a fourth problem. Writer/Html ignores the last row if it contains nothing but a Memory Drawing, which can be true when copying an Xls file.
These changes are testable (it's how I discovered the second part of this parlay). I think it is also useful to add a sample to see the results of this type of copy.
2022-05-07 08:10:24 -07:00
9776efc226
Merge pull request #2811 from PHPOffice/Ods-Writer-Bugfix-Row-Height
...
Fix issue with row height styles in Ods Writer
2022-05-06 21:29:19 +02:00
f7ca14f1f1
Fix issue with row height styles in Ods Writer
2022-05-06 21:16:12 +02:00
779a5e21be
Change Log update
2022-05-06 12:44:04 +02:00
56509d9a3e
Merge pull request #2808 from PHPOffice/Performance-Ods-Writer
...
Performance Ods/Html Writers
2022-05-06 12:42:03 +02:00
d4f6e78c4e
Merge branch 'master' into Performance-Ods-Writer
2022-05-06 12:32:13 +02:00
f9d941a3af
Tweaks to HTML generation, accessing cells directly from the collection
2022-05-06 12:25:47 +02:00
0dc1e9b07a
Switch iterators to use foreach structure
2022-05-06 11:43:10 +02:00
ea165dc52a
Merge pull request #2807 from PHPOffice/Performance-CellIterator
...
Update get cell logic in Cell Iterators
2022-05-06 11:24:24 +02:00
ae09dd13e1
Update logic in Cell Iterators to use Cell Collection directly where appropriate, bypassing the overhead of additional calls through the worksheet with extra checks and validations
2022-05-06 10:11:01 +02:00
7201ddd088
Update get cell logic in Cell Iterators
2022-05-05 16:53:56 +02:00
4a071ce578
Update Change Log
2022-05-05 13:57:28 +02:00
a86ad55a4a
Merge pull request #2806 from PHPOffice/Performance-Xls-Writer
...
Memory Experiment in Xls Writer
2022-05-05 13:53:53 +02:00
b72b423309
Merge pull request #2804 from PHPOffice/Performance-Xlsx-Writer
...
Memory Experiment in Xlsx Writer
2022-05-05 13:49:11 +02:00
1b71e75bc2
Performance Experiment for the Xls Writer, to avoid creating empty cells; and should also be slightly faster
2022-05-05 11:59:25 +02:00
5ae74145de
Performance Experiment for the String Table, to avoid creating empty cells; should also be slightly faster
2022-05-05 10:19:51 +02:00
b399c09dd5
Performance Experiment for the String Table, to avoid creating empty cells; should also be slightly faster
2022-05-05 10:05:32 +02:00
d686a991db
Memory Experiment in Xlsx Writer
2022-05-05 09:44:41 +02:00
48b5d83ee8
Merge pull request #2802 from PHPOffice/Performance-Experimental-Changes
...
Simplify validation of columnId/rowId values when creating a CellAddress object
2022-05-03 13:30:56 +02:00
e043cf3e24
Eliminate loop in `trimSheetFromCellReference()` method
2022-05-03 13:22:43 +02:00
b4fc92ec7e
Simplify validation of columnId/rowId values when creating a CellAddress object
2022-05-03 12:13:10 +02:00
fde77306ff
Merge pull request #2801 from PHPOffice/ScatterChart-Point-Size
...
Add point size option for scatter charts
2022-05-03 09:00:44 +02:00
70f5ec60d7
Add point size option for scatter charts
2022-05-03 08:47:34 +02:00
853cc22913
Merge pull request #2791 from PHPOffice/Named-Range-Alias-Cell-Collection
...
Experiment #143 in memory saving/performance in the Cell Collection
2022-05-01 22:21:52 +02:00
9b99ebda27
Merge branch 'master' into Named-Range-Alias-Cell-Collection
2022-05-01 22:09:26 +02:00
MarkBaker
Mark Baker
oleibman