PhpSpreadsheet/tests/data/Reader
oleibman 5de82981d8
Html Reader Not Handling non-ASCII Data Correctly (#2943)
* Html Reader Not Handling non-ASCII Data Correctly

Fix #2942. Code was changed by #2894 because PHP8.2 will deprecate how it was being done. See linked issue for more details. Dom loadhtml assumes ISO-8859-1 in the absence of a charset attribute or equivalent, and there is no way to override that assumption. Sigh. The suggested replacements are unsuitable in one way or another. I think this will work with minimal disruption (replace ampersand, less than, and greater than with entities representing illegal characters, then use htmlentities, then restore ampersand, less than, and greater than).

* Better Implementation

Use regexp to escape non-ASCII. Less kludgey, less reliant on the vagaries of the PHP maintainers.

* Additional Tests

Test non-ASCII outside of cell contents: sheet title, image alt attribute.

* Apply Same Change in Second Location

Forgot to change loadFromString.

* Additional Test

Confirm escaped ampersand is handled correctly.
2022-07-16 22:08:44 -07:00
..
CSV Php/iconv Should Not Treat FFFE/FFFF as Valid (#2910) 2022-07-02 08:53:39 -07:00
Gnumeric Add support for reading Worksheet Visibility for Gnumeric 2022-05-24 14:08:41 +02:00
HTML Html Reader Not Handling non-ASCII Data Correctly (#2943) 2022-07-16 22:08:44 -07:00
Ods Add support for reading Worksheet Visibility for Ods 2022-05-23 15:30:45 +02:00
Slk Process Comments in Sylk File (#2277) 2021-08-26 11:56:13 -07:00
XLS Add Hidden Worksheet unit tests for other Readers 2022-05-24 14:40:45 +02:00
XLSX Xlsx Chart Reader and Writer Mishandle Explosion Value (#2928) 2022-07-14 07:48:53 -07:00
Xml Extract Property and Style readers from the XML Reader into separate classes (#2009) 2021-04-20 15:27:44 +02:00