Just reviewing Scrutinizer's list of "bugs". There are 19 ascribed to me. For some, I will definitely take no action (e.g. use of bitwise operators in AND, OR, and XOR functions). However, where I can clean things up so that Scrutinizer is satisfied and the resulting code is not too contorted, I will make an attempt. This PR corrects 2 problems according to Scrutinizer, and 1 per Phpstan. Only test members are involved. |
||
|---|---|---|
| .. | ||
| Engine | ||
| Functions | ||
| CalculationTest.php | ||
| DefinedNameConfusedForCellTest.php | ||
| DefinedNamesCalculationTest.php | ||
| FormulaAsStringTest.php | ||
| FunctionsTest.php | ||
| LookupRefTest.php | ||
| MergedCellTest.php | ||
| RowColumnReferenceTest.php | ||
| TranslationTest.php | ||
| XlfnFunctionsTest.php | ||