PhpSpreadsheet/tests/PhpSpreadsheetTests/Reader
oleibman 290c18e4db
Xlsx Reader Theme Support Broken After 17.1 (#2403)
Fix #2387. Fix #2075. There was substantial refactoring of Writer Xlsx styles in 18.0. An existing static property `$theme` was intended to be shared by both Writer Xlsx and the new Writer Xlsx Styles. However, the initialization of the property in the latter happened later than it should have. This PR makes that initialization happen as soon as the theme has been read. Also, declaring that property as static seems questionable; I have made it an instance member. This small re-factoring makes it possible to now support Themes in tab colors.

Since this PR changes Reader/Xlsx/Styles, add type-hinting throughout that module to eliminate Phpstan/Scrutinizer problems. I also removed method readStyle from Reader/Xlsx, since it was essentially duplicated in Reader/Xlsx/Styles. And I added a small number of tests to ensure that Styles is 100% covered. All of this is necessary in preparation for Namespacing phase 2.
2021-11-26 09:38:09 -08:00
..
Csv Csv, Boolean, and StringValueBinder (#2374) 2021-11-12 00:04:08 -08:00
Gnumeric Merge branch 'master' into PHP8-Sane-Property-Names 2021-10-31 15:25:01 +09:00
Html Html import dimension conversions (#2152) 2021-06-11 17:29:49 +02:00
Ods Tweaks to Input File Validation (#2217) 2021-07-24 20:44:04 -07:00
Security Reduce PHPStan error in tests 2021-04-12 11:10:23 +09:00
Slk Process Comments in Sylk File (#2277) 2021-08-26 11:56:13 -07:00
Utility When image source is a URL, store the URL for use during extraction. (#2072) 2021-06-24 10:50:44 +02:00
Xls fix #1114 issue (#2308) 2021-10-03 09:29:23 -07:00
Xlsx Xlsx Reader Theme Support Broken After 17.1 (#2403) 2021-11-26 09:38:09 -08:00
Xml Merge branch 'master' into PHP8-Sane-Property-Names 2021-10-31 15:25:01 +09:00