PhpSpreadsheet/tests/data
oleibman 4001c89aaa
isFormula Referencing Sheet With Space in Title (#2306)
* isFormula Referencing Sheet With Space in Title

See issue #2304. User sets a cell to `ISFORMULA(cell)`, where `cell` exists on a sheet whose title contains a space, and receives an error. Coordinates are not being passed correctly to Functions::isFormula; in particular, the sheet name is not enclosed in apostrophes, e.g. `Sheet Name!A1` rather than `'Sheet Name'!A1`. (Note that sheet name was not specified in Cell; PhpSpreadsheet adds it before calling isFormula.) Sheets without embedded spaces (or other non-word characters) are handled correctly with or without apostrophes, but spaces require surrounding apostrophes.

As part of this investigation, I determined that Excel handles defined names and cell ranges in ISFORMULA (subject to spills), and that PhpSpreadsheet does not. It is changed to handle them. In the absence of spill support, it will use only the first cell in the range.

Existing tests for ISFORMULA used mocking unneccesarily. They are moved to a separate test member, and mocking is no longer used.

* PhpUnit and Jpgraph

35_Char_render.php had previously been a problem only for PHP8+. It is now a problem for PHP7.4, and will therefore be skipped all the time.
2021-10-03 10:04:48 -07:00
..
Calculation isFormula Referencing Sheet With Space in Title (#2306) 2021-10-03 10:04:48 -07:00
Cell PHPCS and PHStan appeasement 2021-06-03 21:42:20 +02:00
Features/AutoFilter/Xlsx Issue 2216 resolve office365 auto filter structure move (#2218) 2021-07-12 03:19:40 +02:00
Functional/TypeAttributePreservation Avoid losing calculated value type 2018-03-03 11:51:06 +01:00
Reader fix #1114 issue (#2308) 2021-10-03 09:29:23 -07:00
Shared Merge branch 'master' into sheetpasswd 2021-07-13 06:11:47 -07:00
Style Fraction Formatting (#2254) 2021-08-18 11:09:37 -07:00
Worksheet Bugfix #1858; Apply stricter scoping rules to named range/cell access (#1866) 2021-02-19 22:03:50 +01:00
Writer Deleting Sheet with Local Defined Name (#2284) 2021-09-15 12:14:13 -07:00
CalculationBinaryComparisonOperation.php Refactor tests data from custom format to PHP 2016-08-16 21:00:19 +09:00
CellAbsoluteCoordinate.php Sheet title can contain exclamation mark (in formulas) 2018-10-03 12:52:51 +09:00
CellAbsoluteReference.php Sheet title can contain exclamation mark (in formulas) 2018-10-03 12:52:51 +09:00
CellBuildRange.php Use proper syntax for variadic functions 2017-01-23 15:01:20 +09:00
CellCoordinates.php PHPStan Level 2 2021-04-04 22:06:00 +09:00
CellExtractAllCellReferencesInRange.php Range operator tests (#1501) 2020-06-02 07:38:35 +02:00
CellGetRangeBoundaries.php Use proper syntax for variadic functions 2017-01-23 15:01:20 +09:00
CellMergeRangesInCollection.php Fix cell ranges causing coordinate merge error 2018-01-22 12:26:37 +09:00
CellRangeBoundaries.php Use proper syntax for variadic functions 2017-01-23 15:01:20 +09:00
CellRangeDimension.php Use proper syntax for variadic functions 2017-01-23 15:01:20 +09:00
CellSplitRange.php Use proper syntax for variadic functions 2017-01-23 15:01:20 +09:00
ColumnIndex.php Consistent `stringFromColumnIndex()` and `columnIndexFromString()` 2017-11-26 15:29:08 +09:00
ColumnString.php Use proper syntax for variadic functions 2017-01-23 15:01:20 +09:00
CoordinateIsRange.php Fix cell ranges causing coordinate merge error 2018-01-22 12:26:37 +09:00
ReferenceHelperFormulaUpdates.php Additional Unit Tests (#1582) 2020-07-14 10:58:50 +02:00
ReferenceHelperFormulaUpdatesMultipleSheet.php Named formula implementation, and improved handling of Defined Names generally (#1535) 2020-07-26 12:00:06 +02:00