PhpSpreadsheet/tests/PhpSpreadsheetTests/Writer
oleibman 9428552d94
Add editAs Property for 2-cell Anchor Drawings (#2674)
* Add editAs Property for 2-cell Anchor Drawings

This change builds on PR #2532 (@naotake51 as PR #2532), using ideas from PR #2237 (@AdamGaskins), which has had changes requested for several months. It covers a lot of the same ground as 2532. In Excel, two-cell anchor drawings can be edited as "twocell", "onecell", or "absolute". This PR adds support for those options, with a sample file that demonstrates the difference in addition to unit tests. Several other tests are added to improve the spotty coverage for Drawings.

There have been several other tickets referencing two cell anchors, including issue #1159 and PR #1160 (@sgarwood, who also added support for editAs), PR #643, and issue #126, all now closed but not necessarily entirely resolved. I will try to ensure that those tickets are addressed with this one.

And, in trying to make sure 1160 is covered, I stumbled upon a bug. If you use the same image resource to create two+ memory drawings, the MemoryDrawing destructor for the first will cause the rest to generate a very long warning message. This is not a problem for Php8+, only for Php7-. I have suppressed the message in the MemoryDrawing constructor. 1160 went stale due to an unresolved test error, but I don't think this was the problem. At any rate, its test works now.

* Scrutinizer

It reported 1 minor issue (fixed normally), and 2 major. One is fixed with a kludge. The other is a case where Scrutinizer's analysis is just wrong, and I can't figure out a kludge. But I was able to add an annotation (the first time I've managed to get one past phpcs/php-cs-fixer). We'll see.
2022-03-16 16:12:38 -07:00
..
Csv Csv Handling of Booleans (and an 8.1 Deprecation) (#2232) 2021-08-04 07:00:17 -07:00
Html Phpstan Differences from Php7 to Php8, Again (#2665) 2022-03-11 23:28:30 -08:00
Mpdf Improve PDF Support for Page Size and Orientation (#2410) 2021-12-01 23:00:02 -08:00
Ods Unit tests for merge ranges for Ods Reader/Writer 2022-02-26 22:51:15 +01:00
Xls Merge branch 'master' into PHP8-Sane-Property-Names 2021-10-31 15:25:01 +09:00
Xlsx Add editAs Property for 2-cell Anchor Drawings (#2674) 2022-03-16 16:12:38 -07:00
PreCalcTest.php Scrutinizer and Phpstan 2021-05-29 12:52:11 +02:00
RetainSelectedCellsTest.php Reduce PHPStan error in tests 2021-04-12 11:10:23 +09:00