766252ccb0
* Real Errors Identified in Calculation by Scrutinizer Before Scrutinizer broke, I took a look at the remaining 43 errors which it categorized as 'major'. Most of these were false positives, but, in the case of Calculation and Reader/Xlsx/Chart, I was able to determine that its analysis of some of the problems was correct. There is little point addressing the false positives until it starts working again, but we should fix the real errors. This PR addresses the real errors in Calculation. - A test for `$pCellParent` should have been a test for `$pCellWorksheet`. - A test for `$operand1Data['reference']` should have been a test for `$operand1Data['value']`. - A test for `$operand2Data['reference']` should have been a test for `$operand2Data['value']`. * Fix Attempt to Erroneously Call trim on Array Fix #2780. Warning message is being issued when getting calculated value of cell with value `=INDIRECT(ADDRESS(ROW(),COLUMN()-2))/$C$4`. This appears to be the case for all recent (and probably not so recent) releases; it is not a result of changes to the code base. Fix added to this PR because the erring section of code was proximate to code already changed in the PR. Test added. * Minor Code Changes Apply some suggestions from @MarkBaker |
||
|---|---|---|
| .. | ||
| Csv | ||
| Gnumeric | ||
| Html | ||
| Ods | ||
| Security | ||
| Slk | ||
| Utility | ||
| Xls | ||
| Xlsx | ||
| Xml | ||