PhpSpreadsheet/tests
oleibman 9512f54cca
Corrections for Xlsx Read Comments (#2329)
This change was suggested by issue #2316. There was a problem reading Xlsx comments which appeared with release 18.0 but which was already fixed in master. So no source change was needed to fix the issue, but I thought we should at least add the test case to our unit tests.

In developing that case, I discovered that, although comment text was read correctly, there was a problem with comment author. In fact, there were two problems. One was new, with the namespacing changes - as in several other cases, the namespaced attribute `authorId` needed some special handling. However, another problem was much older - the code was checking `!empty($comment['authorId'])`, eliminating consideration of authorId=0, and should instead have been checking `isset`. Both problems are now fixed, and tested.
2021-10-23 17:32:44 -07:00
..
PhpSpreadsheetTests Corrections for Xlsx Read Comments (#2329) 2021-10-23 17:32:44 -07:00
data Corrections for Xlsx Read Comments (#2329) 2021-10-23 17:32:44 -07:00
bootstrap.php 100% Coverage for Calculation/DateTime (#1870) 2021-02-27 20:43:22 +01:00