PhpSpreadsheet/tests/PhpSpreadsheetTests/Reader/Xlsx
oleibman ad5532e2f4
Namespacing Phase 2 - Styles (#2471)
* WIP Namespacing Phase 2 - Styles

This is part 2 of a several-phase process to permit PhpSpreadsheet to handle input Xlsx files which use unexpected namespacing. The first phase, introduced as part of release 1.19.0, essentially handled the reading of data. This phase handles the reading of styles. More phases are planned.

It is my intention to leave this in draft status for at least a month. This will give time for additional testing, by me and, I hope, others who might be interested.

This fixes the same problem addressed by PR #2458, if it reaches mergeable status before I am ready to take this out of draft status. I do not anticipate any difficult merge conflicts if the other change is merged first.

This change is more difficult than I'd hoped. I can't get xpath to work properly with the namespaced style file, even though I don't have difficulties with others. Normally we expect:
```xml
<stylesheet xmlns="http://whatever" ...
```
In the namespaced files, we typically see:
```xml
<x:stylesheet xmlns:x="http://whatever" ...
```

Simplexml_load_file specifying a namespace handles the two situations the same, as expected. But, for some reason that I cannot figure out, there are significant differences when xpath processes the result. However, I can manipulate the xml if necessary; I'm not proud of doing that, and will gladly accept any suggestions. In the meantime, it seems to work.

My major non-standard unit test file had disabled any style-related tests when phase 1 was installed. These are now all enabled.

* Scrutinizer

Its analysis is wrong, but the "errors" it pointed out are easy to fix.

* Eliminate XML Source Manipulation

Original solution required XML manipulation to overcome what appears to be an xpath problem. This version replaces xpath with iteration, eliminating the need to manipulate the XML.

* Handle Some Edge Cases

For example, Style file without a Fills section.

* Restore RGB/ARGB Interchangeability

Fix #2494. Apparently EPPlus outputs fill colors as `<fgColor rgb="BFBFBF">` while most output fill colors as `<fgColor rgb="FFBFBFBF">`. EPPlus actually makes more sense. Regardless, validating length of rgb/argb is a recent development for PhpSpreadsheet, under the assumption that an incorrect length is a user error. This development invalidates that assumption, so restore the previous behavior.

In addition, a comment in Colors.php says that the supplied color is "the ARGB value for the colour, or named colour". However, although named colors are accepted, nothing sensible is done with them - they are passed unchanged to the ARGB value, where Excel treats them as black. The routine should either reject the named color, or convert it to the appropriate ARGB value. This change implements the latter.
2022-02-11 06:42:04 -08:00
..
AbsolutePathTest.php Remove unnecessary changes. Added test 2021-04-19 11:25:48 +01:00
AutoFilterEvaluateTest.php Xlsx Writer Unhides Explicitly Hidden Row in Filter Range - Minor Breaking Change (#2414) 2021-12-05 07:26:24 -08:00
AutoFilterTest.php Reduce PHPStan error in tests 2021-04-12 11:10:23 +09:00
ChartsTitleTest.php DocBlock Changes for Chart/Title 2021-07-02 14:33:43 -07:00
ColorTabTest.php Xlsx Reader Theme Support Broken After 17.1 (#2403) 2021-11-26 09:38:09 -08:00
CommentTest.php Corrections for Xlsx Read Comments (#2329) 2021-10-23 17:32:44 -07:00
CondNumFmtTest.php Move Reader Xlsx Tests from Reader to Reader/Xlsx Try 2 2021-06-17 09:45:11 -07:00
ConditionalFormattingDataBarXlsxTest.php Reduce PHPStan error in tests 2021-04-12 11:10:23 +09:00
ConditionalTest.php #984 fix php-cs-fixer warnings 2021-05-11 12:44:40 +02:00
CoverageGapsTest.php Xlsx Reader Theme Support Broken After 17.1 (#2403) 2021-11-26 09:38:09 -08:00
DataValidationBooleanValue.php Fix test names per `composer check` 2021-07-21 05:53:49 -07:00
DefaultFillTest.php Resolve issue with conditional font size set to zero in PHP8 (#2073) 2021-05-07 12:53:59 +02:00
DefaultFontTest.php Resolve issue with conditional font size set to zero in PHP8 (#2073) 2021-05-07 12:53:59 +02:00
DrawingOneCellAnchorTest.php Fix loading drawing size (#2492) 2022-01-16 21:59:31 -08:00
EmptyFileTest.php Tweaks to Input File Validation (#2217) 2021-07-24 20:44:04 -07:00
ExplicitDateTest.php Handle Explicit "Date" Type for Cell (#2485) 2022-01-13 18:40:18 -08:00
HyperlinkTest.php Hyperlinks and Namespacing (#2391) 2021-11-14 10:27:59 -08:00
InvalidFileTest.php Tweaks to Input File Validation (#2217) 2021-07-24 20:44:04 -07:00
Issue2301Test.php Xlsx Reader Better Namespace Handling Phase 1 Second Bugfix (#2303) 2021-09-27 16:59:45 -07:00
Issue2331Test.php Unexpected Format in Timestamp (#2332) 2021-10-23 18:23:53 -07:00
Issue2362Test.php ZipArchive and "Inconsistent" Zip File (#2376) 2021-11-12 01:18:57 -08:00
Issue2387Test.php Xlsx Reader Theme Support Broken After 17.1 (#2403) 2021-11-26 09:38:09 -08:00
Issue2450Test.php General Style Specified in Uppercase in Input Xlsx (#2451) 2021-12-18 09:25:08 -08:00
Issue2488Test.php Xlsx Reader Cell DataType Numeric or Boolean Without Value (#2489) 2022-01-16 21:19:09 -08:00
Issue2494Test.php Namespacing Phase 2 - Styles (#2471) 2022-02-11 06:42:04 -08:00
Issue2501Test.php Xlsx Reader Merge Range For Entire Column(s) or Row(s) (#2504) 2022-01-23 10:44:09 -08:00
Issue2516Test.php fix warning when open xlsx file with thumbnail (#2517) 2022-01-24 14:17:53 -08:00
NamedRangeTest.php Fix for 3 Issues Involving ReadXlsx and NamedRange (#1742) 2020-12-10 18:08:10 +01:00
NamespaceIssue2109bTest.php Rename Two Test Files (#2459) 2021-12-25 09:05:54 -08:00
NamespaceNonStdTest.php Namespacing Phase 2 - Styles (#2471) 2022-02-11 06:42:04 -08:00
NamespaceOpenpyxl35Test.php Rename Two Test Files (#2459) 2021-12-25 09:05:54 -08:00
NamespacePurlTest.php Xlsx Reader Better Namespace Handling Phase 1 Try2 (#2173) 2021-06-25 09:05:49 +02:00
NamespaceStdTest.php Xlsx Reader Better Namespace Handling Phase 1 Try2 (#2173) 2021-06-25 09:05:49 +02:00
OctothorpeTest.php Read Spreadsheet with # in Name (#2409) 2021-11-30 07:39:50 -08:00
OddColumnReadFilter.php Merge branch 'master' into PHP8-Sane-Property-Names 2021-10-31 15:25:01 +09:00
PageSetupTest.php Stricter visibility 2020-07-19 12:30:31 +09:00
PropertiesTest.php Document Properties - Coverage and 32-bit-safe Timestamps (#2113) 2021-05-30 13:55:58 +02:00
RichTextTest.php Namespacing Phase 2 - Styles (#2471) 2022-02-11 06:42:04 -08:00
SharedFormulaTest.php Xlsx Reader Better Namespace Handling Phase 1 First Bugfix (#2204) 2021-07-02 12:36:54 +02:00
SheetsXlsxChartTest.php Move Reader Xlsx Tests from Reader to Reader/Xlsx Try 2 2021-06-17 09:45:11 -07:00
URLImageTest.php Allow Skipping One Unit Test (#2402) 2021-11-19 14:24:42 -08:00
WorksheetInfoNamesTest.php Xlsx Reader Better Namespace Handling Phase 1 Try2 (#2173) 2021-06-25 09:05:49 +02:00
Xlsx2Test.php Read conditional styling for cell (#2491) 2022-01-22 19:18:26 +01:00
XlsxTest.php Fix Reading XLSX files without styles.xml throws an exception. (#2247) 2021-08-16 05:05:32 -07:00