PhpSpreadsheet/tests/PhpSpreadsheetTests/Calculation
oleibman b6bd822b9c
Xlsx Reader Merge Range For Entire Column(s) or Row(s) (#2504)
* Xlsx Reader Merge Range For Entire Column(s) or Row(s)

Fix #2501. Merge range can be supplied as entire rows or columns, e.g. `1:1` or `A:C`. PhpSpreadsheet is expecting a row and a column to be specified for both parts of the range, and fails when the unexpected format shows up.

The code to clear cells within the merge range is very inefficient in terms of both memory and time, especially when the range is large (e.g. for an entire row or column). More efficient code is substituted. It is possible that we can get even more efficient by deleting the cleared cells rather than setting them to null. However, that needs more research, and there is no reason to delay this fix while I am researching.

When Xlsx Writer encounters a null cell, it writes it to the output file. For cell merges (especially involving whole rows or columns), this results in a lot of useless output. It is changed to skip the output of null cells when (a) the cell style matches its row's style, or (b) the row style is not specified and the cell style matches its column's style.

* Scrutinizer

See if these changes appease it.

* Improved CellIterators

Finally figured out how to improve efficiency here, meaning that there is no longer a reason to change Writer/Xlsx, so restore that.

* No Change for CellIterator

I had thought a change was needed for CellIterator, but it isn't.
2022-01-23 10:44:09 -08:00
..
Engine Reduce PHPStan error in tests 2021-04-12 11:10:23 +09:00
Functions Refinement for XIRR (#2487) 2022-01-13 19:31:46 -08:00
CalculationErrorTest.php New Error Reported with Phpstan 1.3 (#2481) 2022-01-03 17:32:52 -08:00
CalculationTest.php Some simplification to the locale file loader 2021-05-20 20:41:09 +02:00
DefinedNameConfusedForCellTest.php Reduce PHPStan error in tests 2021-04-12 11:10:23 +09:00
DefinedNamesCalculationTest.php Named formula implementation, and improved handling of Defined Names generally (#1535) 2020-07-26 12:00:06 +02:00
FormulaAsStringTest.php Reduce PHPStan error in tests 2021-04-12 11:10:23 +09:00
FunctionsTest.php isFormula Referencing Sheet With Space in Title (#2306) 2021-10-03 10:04:48 -07:00
IsFormulaTest.php isFormula Referencing Sheet With Space in Title (#2306) 2021-10-03 10:04:48 -07:00
MergedCellTest.php Xlsx Reader Merge Range For Entire Column(s) or Row(s) (#2504) 2022-01-23 10:44:09 -08:00
RowColumnReferenceTest.php Improve Range handling in the Calculation Engine for Row and Column ranges (#2028) 2021-04-27 19:10:37 +02:00
TranslationTest.php Reduce PHPStan error in tests 2021-04-12 11:10:23 +09:00
XlfnFunctionsTest.php Reduce PHPStan error in tests 2021-04-12 11:10:23 +09:00