From 7785241e1235b62f3d4821d2fb8cf16f99744d29 Mon Sep 17 00:00:00 2001 From: Toby Zerner Date: Sun, 5 Sep 2021 17:24:18 +1000 Subject: [PATCH] 400 when attempting to filter on an attribute of a polymorphic relationship --- src/ResourceType.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/ResourceType.php b/src/ResourceType.php index 249d8b3..5d9e823 100644 --- a/src/ResourceType.php +++ b/src/ResourceType.php @@ -157,8 +157,12 @@ final class ResourceType $this->adapter->filterByRelationship($query, $field, function ($query) use ($relatedResource, $sub, $value, $context) { $relatedResource->applyFilters($query, [($sub ?? 'id') => $value], $context); }); + + continue; } - continue; + + throw (new BadRequestException('Cannot filter on attribute of polymorphic relationship: '.$name)) + ->setSourceParameter("filter[$name]"); } }