From 15602d8e973fa887f2cbfb9fdfa19d028e04ba48 Mon Sep 17 00:00:00 2001 From: PJ Dietz Date: Fri, 15 May 2015 19:11:43 -0400 Subject: [PATCH] Remove suppression operator from RegexRoute --- src/Routing/Route/RegexRoute.php | 2 +- test/tests/unit/Routing/Route/RegexRouteTest.php | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/Routing/Route/RegexRoute.php b/src/Routing/Route/RegexRoute.php index 2d39a99..4afd45a 100644 --- a/src/Routing/Route/RegexRoute.php +++ b/src/Routing/Route/RegexRoute.php @@ -20,7 +20,7 @@ class RegexRoute extends Route public function matchesRequestTarget($requestTarget) { $this->captures = []; - $matched = @preg_match($this->getTarget(), $requestTarget, $captures); + $matched = preg_match($this->getTarget(), $requestTarget, $captures); if ($matched) { $this->captures = $captures; return true; diff --git a/test/tests/unit/Routing/Route/RegexRouteTest.php b/test/tests/unit/Routing/Route/RegexRouteTest.php index 80268a4..3c7de1b 100644 --- a/test/tests/unit/Routing/Route/RegexRouteTest.php +++ b/test/tests/unit/Routing/Route/RegexRouteTest.php @@ -106,7 +106,14 @@ class RegexRouteTest extends \PHPUnit_Framework_TestCase public function testThrowsExceptionOnInvalidPattern($pattern) { $route = new RegexRoute($pattern, $this->methodMap->reveal()); + \PHPUnit_Framework_Error_Warning::$enabled = false; + \PHPUnit_Framework_Error_Notice::$enabled = false; + $level = error_reporting(); + error_reporting($level & ~E_WARNING); $route->matchesRequestTarget("/"); + error_reporting($level); + \PHPUnit_Framework_Error_Warning::$enabled = true; + \PHPUnit_Framework_Error_Notice::$enabled = true; } public function invalidRouteProvider()