Clientbase
/
wellrested
mirror of https://github.com/basemaster/wellrested.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Update PrefixRoute tests

This commit is contained in:
PJ Dietz 2015-02-18 20:47:45 -05:00
parent 38aaf26943
commit 63fd00fff0
2 changed files with 54 additions and 62 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/pjdietz/WellRESTed/Routes/PrefixRoute.php
View File

@ -25,19 +25,19 @@ class PrefixRoute extends BaseRoute implements PrefixRouteInterface
/**
* Create a new StaticRoute for a given path or paths and a handler class.
*
* @param string|array $prefixes Path or list of paths the request must match
* @param string $targetClassName Fully qualified name to an autoloadable handler class.
* @param string|array $path Path or list of paths the request must match
* @param string $target Fully qualified name to an autoloadable handler class.
* @throws \InvalidArgumentException
*/
public function __construct($prefixes, $targetClassName)
public function __construct($path, $target)
{
parent::__construct($targetClassName);
if (is_string($prefixes)) {
$this->prefixes = array($prefixes);
} elseif (is_array($prefixes)) {
$this->prefixes = $prefixes;
parent::__construct($target);
if (is_string($path)) {
$this->prefixes = array($path);
} elseif (is_array($path)) {
$this->prefixes = $path;
} else {
throw new InvalidArgumentException("$prefixes must be a string or array of string");
throw new InvalidArgumentException("$path must be a string or array of string");
}
}

98
test/Routes/PrefixRouteTest.php
View File

@ -2,63 +2,47 @@
namespace pjdietz\WellRESTed\Test;
use pjdietz\WellRESTed\Interfaces\HandlerInterface;
use pjdietz\WellRESTed\Response;
use pjdietz\WellRESTed\Routes\PrefixRoute;
use Prophecy\Argument;
/**
* @covers pjdietz\WellRESTed\Routes\PrefixRoute
*/
class PrefixRouteTest extends \PHPUnit_Framework_TestCase
{
public function testMatchSinglePathExactly()
private $handler;
private $request;
private $response;
public function testMatchesSinglePathExactly()
{
$path = "/";
$mockRequest = $this->getMock('\pjdietz\WellRESTed\Interfaces\RequestInterface');
$mockRequest->expects($this->any())
->method('getPath')
->will($this->returnValue($path));
$route = new PrefixRoute($path, __NAMESPACE__ . '\PrefixRouteTestHandler');
$resp = $route->getResponse($mockRequest);
$this->request->getPath()->willReturn("/cats/");
$route = new PrefixRoute("/cats/", $this->handler->reveal());
$resp = $route->getResponse($this->request->reveal());
$this->assertNotNull($resp);
}
public function testMatchSinglePathWithPrefix()
public function testMatchesSinglePathWithPrefix()
{
$mockRequest = $this->getMock('\pjdietz\WellRESTed\Interfaces\RequestInterface');
$mockRequest->expects($this->any())
->method('getPath')
->will($this->returnValue("/cats/"));
$route = new PrefixRoute("/", __NAMESPACE__ . '\PrefixRouteTestHandler');
$resp = $route->getResponse($mockRequest);
$this->request->getPath()->willReturn("/cats/molly");
$route = new PrefixRoute("/cats/", $this->handler->reveal());
$resp = $route->getResponse($this->request->reveal());
$this->assertNotNull($resp);
}
public function testMatchPathInList()
public function testMatchesPathInList()
{
$paths = array("/cats/", "/dogs/");
$mockRequest = $this->getMock('\pjdietz\WellRESTed\Interfaces\RequestInterface');
$mockRequest->expects($this->any())
->method('getPath')
->will($this->returnValue("/cats/"));
$route = new PrefixRoute($paths, __NAMESPACE__ . '\StaticRouteTestHandler');
$resp = $route->getResponse($mockRequest);
$this->assertEquals(200, $resp->getStatusCode());
$this->request->getPath()->willReturn("/cats/molly");
$route = new PrefixRoute(array("/cats/", "/dogs/"), $this->handler->reveal());
$resp = $route->getResponse($this->request->reveal());
$this->assertNotNull($resp);
}
public function testFailToMatchPath()
public function testFailsToMatchPath()
{
$path = "/cat/";
$mockRequest = $this->getMock('\pjdietz\WellRESTed\Interfaces\RequestInterface');
$mockRequest->expects($this->any())
->method('getPath')
->will($this->returnValue("/not-this-path/"));
$route = new PrefixRoute($path, 'NoClass');
$resp = $route->getResponse($mockRequest);
$this->request->getPath()->willReturn("/dogs/");
$route = new PrefixRoute("/cats/", $this->handler->reveal());
$resp = $route->getResponse($this->request->reveal());
$this->assertNull($resp);
}
@ -66,9 +50,9 @@ class PrefixRouteTest extends \PHPUnit_Framework_TestCase
* @dataProvider invalidPathsProvider
* @expectedException \InvalidArgumentException
*/
public function testFailOnInvalidPath($path)
public function testThrowsExceptionOnInvalidPath($path)
{
new PrefixRoute($path, 'NoClass');
new PrefixRoute($path, "\\NoClass");
}
public function invalidPathsProvider()
@ -79,17 +63,25 @@ class PrefixRouteTest extends \PHPUnit_Framework_TestCase
array(null)
);
}
}
/**
* Mini Handler class that allways returns a 200 status code Response.
*/
class PrefixRouteTestHandler implements HandlerInterface
{
public function getResponse(\pjdietz\WellRESTed\Interfaces\RequestInterface $request, array $args = null)
public function testReturnsHandler()
{
$resp = new Response();
$resp->setStatusCode(200);
return $resp;
$route = new PrefixRoute("/cats/", $this->handler->reveal());
$this->assertNotNull($route->getHandler());
}
public function testReturnsPrefixes()
{
$paths = array("/cats/", "/dogs/");
$route = new PrefixRoute($paths, $this->handler->reveal());
$this->assertEquals($paths, $route->getPrefixes());
}
public function setUp()
{
$this->request = $this->prophesize("\\pjdietz\\WellRESTed\\Interfaces\\RequestInterface");
$this->response = $this->prophesize("\\pjdietz\\WellRESTed\\Interfaces\\ResponseInterface");
$this->handler = $this->prophesize("\\pjdietz\\WellRESTed\\Interfaces\\HandlerInterface");
$this->handler->getResponse(Argument::cetera())->willReturn($this->response->reveal());
}
}