Refactor message tests

This commit is contained in:
PJ Dietz 2016-05-20 20:08:48 -04:00
parent d3e924485c
commit 929f8ffd97
9 changed files with 78 additions and 686 deletions

View File

@ -5,25 +5,11 @@ namespace WellRESTed\Test\Message;
use WellRESTed\Message\HeaderCollection; use WellRESTed\Message\HeaderCollection;
/** /**
* @coversDefaultClass WellRESTed\Message\HeaderCollection * @covers WellRESTed\Message\HeaderCollection
* @uses WellRESTed\Message\HeaderCollection
* @group message * @group message
*/ */
class HeaderCollectionTest extends \PHPUnit_Framework_TestCase class HeaderCollectionTest extends \PHPUnit_Framework_TestCase
{ {
/**
* @covers ::__construct
*/
public function testCreatesInstance()
{
$collection = new HeaderCollection();
$this->assertNotNull($collection);
}
/**
* @covers ::offsetSet
* @covers ::offsetExists
*/
public function testAddsSingleHeaderAndIndicatesCaseInsensitiveIsset() public function testAddsSingleHeaderAndIndicatesCaseInsensitiveIsset()
{ {
$collection = new HeaderCollection(); $collection = new HeaderCollection();
@ -31,10 +17,6 @@ class HeaderCollectionTest extends \PHPUnit_Framework_TestCase
$this->assertTrue(isset($collection["content-type"])); $this->assertTrue(isset($collection["content-type"]));
} }
/**
* @covers ::offsetSet
* @covers ::offsetExists
*/
public function testAddsMultipleHeadersAndIndicatesCaseInsensitiveIsset() public function testAddsMultipleHeadersAndIndicatesCaseInsensitiveIsset()
{ {
$collection = new HeaderCollection(); $collection = new HeaderCollection();
@ -43,9 +25,6 @@ class HeaderCollectionTest extends \PHPUnit_Framework_TestCase
$this->assertTrue(isset($collection["set-cookie"])); $this->assertTrue(isset($collection["set-cookie"]));
} }
/**
* @covers ::offsetGet
*/
public function testReturnsHeadersWithCaseInsensitiveHeaderName() public function testReturnsHeadersWithCaseInsensitiveHeaderName()
{ {
$collection = new HeaderCollection(); $collection = new HeaderCollection();
@ -56,9 +35,6 @@ class HeaderCollectionTest extends \PHPUnit_Framework_TestCase
$this->assertEquals(2, count(array_intersect($headers, ["cat=Molly", "dog=Bear"]))); $this->assertEquals(2, count(array_intersect($headers, ["cat=Molly", "dog=Bear"])));
} }
/**
* @covers ::offsetUnset
*/
public function testRemovesHeadersWithCaseInsensitiveHeaderName() public function testRemovesHeadersWithCaseInsensitiveHeaderName()
{ {
$collection = new HeaderCollection(); $collection = new HeaderCollection();
@ -68,9 +44,7 @@ class HeaderCollectionTest extends \PHPUnit_Framework_TestCase
$this->assertFalse(isset($collection["set-cookie"])); $this->assertFalse(isset($collection["set-cookie"]));
} }
/** /** @coversNothing */
* @coversNothing
*/
public function testCloneMakesDeepCopyOfHeaders() public function testCloneMakesDeepCopyOfHeaders()
{ {
$collection = new HeaderCollection(); $collection = new HeaderCollection();
@ -82,13 +56,6 @@ class HeaderCollectionTest extends \PHPUnit_Framework_TestCase
$this->assertTrue(isset($collection["set-cookie"]) && !isset($clone["set-cookie"])); $this->assertTrue(isset($collection["set-cookie"]) && !isset($clone["set-cookie"]));
} }
/**
* @covers ::current
* @covers ::next
* @covers ::key
* @covers ::valid
* @covers ::rewind
*/
public function testIteratesWithOriginalKeys() public function testIteratesWithOriginalKeys()
{ {
$collection = new HeaderCollection(); $collection = new HeaderCollection();
@ -110,13 +77,6 @@ class HeaderCollectionTest extends \PHPUnit_Framework_TestCase
$this->assertEquals(0, $countUnmatched); $this->assertEquals(0, $countUnmatched);
} }
/**
* @covers ::current
* @covers ::next
* @covers ::key
* @covers ::valid
* @covers ::rewind
*/
public function testIteratesWithOriginalKeysAndValues() public function testIteratesWithOriginalKeysAndValues()
{ {
$collection = new HeaderCollection(); $collection = new HeaderCollection();

View File

@ -3,25 +3,11 @@
namespace WellRESTed\Test\Unit\Message; namespace WellRESTed\Test\Unit\Message;
/** /**
* @coversDefaultClass WellRESTed\Message\Message * @covers WellRESTed\Message\Message
* @uses WellRESTed\Message\Message
* @uses WellRESTed\Message\HeaderCollection
* @group message * @group message
*/ */
class MessageTest extends \PHPUnit_Framework_TestCase class MessageTest extends \PHPUnit_Framework_TestCase
{ {
/**
* @covers ::__construct
*/
public function testCreatesInstance()
{
$message = $this->getMockForAbstractClass('\WellRESTed\Message\Message');
$this->assertNotNull($message);
}
/**
* @covers ::__construct
*/
public function testSetsHeadersOnConstruction() public function testSetsHeadersOnConstruction()
{ {
$headers = ["X-foo" => ["bar", "baz"]]; $headers = ["X-foo" => ["bar", "baz"]];
@ -30,9 +16,6 @@ class MessageTest extends \PHPUnit_Framework_TestCase
$this->assertEquals(["bar", "baz"], $message->getHeader("X-foo")); $this->assertEquals(["bar", "baz"], $message->getHeader("X-foo"));
} }
/**
* @covers ::__construct
*/
public function testSetsBodyOnConstruction() public function testSetsBodyOnConstruction()
{ {
$headers = null; $headers = null;
@ -41,10 +24,7 @@ class MessageTest extends \PHPUnit_Framework_TestCase
$this->assertSame($body->reveal(), $message->getBody()); $this->assertSame($body->reveal(), $message->getBody());
} }
/** public function testCloneMakesDeepCopyOfHeaders()
* @covers ::__clone
*/
public function testCloneMakesDeepCopyOfHeaders()
{ {
$message1 = $this->getMockForAbstractClass('\WellRESTed\Message\Message'); $message1 = $this->getMockForAbstractClass('\WellRESTed\Message\Message');
$message1 = $message1->withHeader("Content-type", "text/plain"); $message1 = $message1->withHeader("Content-type", "text/plain");
@ -55,18 +35,12 @@ class MessageTest extends \PHPUnit_Framework_TestCase
// ------------------------------------------------------------------------ // ------------------------------------------------------------------------
// Protocol Version // Protocol Version
/**
* @covers ::getProtocolVersion
*/
public function testGetProtocolVersionReturnsProtocolVersion1Point1ByDefault() public function testGetProtocolVersionReturnsProtocolVersion1Point1ByDefault()
{ {
$message = $this->getMockForAbstractClass('\WellRESTed\Message\Message'); $message = $this->getMockForAbstractClass('\WellRESTed\Message\Message');
$this->assertEquals("1.1", $message->getProtocolVersion()); $this->assertEquals("1.1", $message->getProtocolVersion());
} }
/**
* @covers ::getProtocolVersion
*/
public function testGetProtocolVersionReturnsProtocolVersion() public function testGetProtocolVersionReturnsProtocolVersion()
{ {
$message = $this->getMockForAbstractClass('\WellRESTed\Message\Message'); $message = $this->getMockForAbstractClass('\WellRESTed\Message\Message');
@ -74,9 +48,6 @@ class MessageTest extends \PHPUnit_Framework_TestCase
$this->assertEquals("1.0", $message->getProtocolVersion()); $this->assertEquals("1.0", $message->getProtocolVersion());
} }
/**
* @covers ::withProtocolVersion
*/
public function testGetProtocolVersionReplacesProtocolVersion() public function testGetProtocolVersionReplacesProtocolVersion()
{ {
$message = $this->getMockForAbstractClass('\WellRESTed\Message\Message'); $message = $this->getMockForAbstractClass('\WellRESTed\Message\Message');
@ -87,11 +58,7 @@ class MessageTest extends \PHPUnit_Framework_TestCase
// ------------------------------------------------------------------------ // ------------------------------------------------------------------------
// Headers // Headers
/** /** @dataProvider validHeaderValueProvider */
* @covers ::withHeader
* @covers ::getValidatedHeaders
* @dataProvider validHeaderValueProvider
*/
public function testWithHeaderReplacesHeader($expected, $value) public function testWithHeaderReplacesHeader($expected, $value)
{ {
$message = $this->getMockForAbstractClass('\WellRESTed\Message\Message'); $message = $this->getMockForAbstractClass('\WellRESTed\Message\Message');
@ -109,8 +76,6 @@ class MessageTest extends \PHPUnit_Framework_TestCase
} }
/** /**
* @covers ::withHeader
* @covers ::getValidatedHeaders
* @expectedException \InvalidArgumentException * @expectedException \InvalidArgumentException
* @dataProvider invalidHeaderProvider * @dataProvider invalidHeaderProvider
*/ */
@ -129,9 +94,6 @@ class MessageTest extends \PHPUnit_Framework_TestCase
]; ];
} }
/**
* @covers ::withAddedHeader
*/
public function testWithAddedHeaderSetsHeader() public function testWithAddedHeaderSetsHeader()
{ {
$message = $this->getMockForAbstractClass('\WellRESTed\Message\Message'); $message = $this->getMockForAbstractClass('\WellRESTed\Message\Message');
@ -139,9 +101,6 @@ class MessageTest extends \PHPUnit_Framework_TestCase
$this->assertEquals(["application/json"], $message->getHeader("Content-type")); $this->assertEquals(["application/json"], $message->getHeader("Content-type"));
} }
/**
* @covers ::withAddedHeader
*/
public function testWithAddedHeaderAppendsValue() public function testWithAddedHeaderAppendsValue()
{ {
$message = $this->getMockForAbstractClass('\WellRESTed\Message\Message'); $message = $this->getMockForAbstractClass('\WellRESTed\Message\Message');
@ -151,9 +110,6 @@ class MessageTest extends \PHPUnit_Framework_TestCase
$this->assertTrue(in_array("cat=Molly", $cookies) && in_array("dog=Bear", $cookies)); $this->assertTrue(in_array("cat=Molly", $cookies) && in_array("dog=Bear", $cookies));
} }
/**
* @covers ::withoutHeader
*/
public function testWithoutHeaderRemovesHeader() public function testWithoutHeaderRemovesHeader()
{ {
$message = $this->getMockForAbstractClass('\WellRESTed\Message\Message'); $message = $this->getMockForAbstractClass('\WellRESTed\Message\Message');
@ -162,18 +118,12 @@ class MessageTest extends \PHPUnit_Framework_TestCase
$this->assertFalse($message->hasHeader("Content-type")); $this->assertFalse($message->hasHeader("Content-type"));
} }
/**
* @covers ::getHeader
*/
public function testGetHeaderReturnsEmptyArrayForUnsetHeader() public function testGetHeaderReturnsEmptyArrayForUnsetHeader()
{ {
$message = $this->getMockForAbstractClass('\WellRESTed\Message\Message'); $message = $this->getMockForAbstractClass('\WellRESTed\Message\Message');
$this->assertEquals([], $message->getHeader("X-name")); $this->assertEquals([], $message->getHeader("X-name"));
} }
/**
* @covers ::getHeader
*/
public function testGetHeaderReturnsSingleHeader() public function testGetHeaderReturnsSingleHeader()
{ {
$message = $this->getMockForAbstractClass('\WellRESTed\Message\Message'); $message = $this->getMockForAbstractClass('\WellRESTed\Message\Message');
@ -181,9 +131,6 @@ class MessageTest extends \PHPUnit_Framework_TestCase
$this->assertEquals(["application/json"], $message->getHeader("Content-type")); $this->assertEquals(["application/json"], $message->getHeader("Content-type"));
} }
/**
* @covers ::getHeader
*/
public function testGetHeaderReturnsMultipleValuesForHeader() public function testGetHeaderReturnsMultipleValuesForHeader()
{ {
$message = $this->getMockForAbstractClass('\WellRESTed\Message\Message'); $message = $this->getMockForAbstractClass('\WellRESTed\Message\Message');
@ -192,18 +139,12 @@ class MessageTest extends \PHPUnit_Framework_TestCase
$this->assertEquals(["cat=Molly", "dog=Bear"], $message->getHeader("X-name")); $this->assertEquals(["cat=Molly", "dog=Bear"], $message->getHeader("X-name"));
} }
/**
* @covers ::getHeaderLine
*/
public function testGetHeaderLineReturnsEmptyStringForUnsetHeader() public function testGetHeaderLineReturnsEmptyStringForUnsetHeader()
{ {
$message = $this->getMockForAbstractClass('\WellRESTed\Message\Message'); $message = $this->getMockForAbstractClass('\WellRESTed\Message\Message');
$this->assertSame("", $message->getHeaderLine("X-not-set")); $this->assertSame("", $message->getHeaderLine("X-not-set"));
} }
/**
* @covers ::getHeaderLine
*/
public function testGetHeaderLineReturnsMultipleHeadersJoinedByCommas() public function testGetHeaderLineReturnsMultipleHeadersJoinedByCommas()
{ {
$message = $this->getMockForAbstractClass('\WellRESTed\Message\Message'); $message = $this->getMockForAbstractClass('\WellRESTed\Message\Message');
@ -212,9 +153,6 @@ class MessageTest extends \PHPUnit_Framework_TestCase
$this->assertEquals("cat=Molly, dog=Bear", $message->getHeaderLine("X-name")); $this->assertEquals("cat=Molly, dog=Bear", $message->getHeaderLine("X-name"));
} }
/**
* @covers ::hasHeader
*/
public function testHasHeaderReturnsTrueWhenHeaderIsSet() public function testHasHeaderReturnsTrueWhenHeaderIsSet()
{ {
$message = $this->getMockForAbstractClass('\WellRESTed\Message\Message'); $message = $this->getMockForAbstractClass('\WellRESTed\Message\Message');
@ -222,18 +160,12 @@ class MessageTest extends \PHPUnit_Framework_TestCase
$this->assertTrue($message->hasHeader("Content-type")); $this->assertTrue($message->hasHeader("Content-type"));
} }
/**
* @covers ::hasHeader
*/
public function testHasHeaderReturnsFalseWhenHeaderIsNotSet() public function testHasHeaderReturnsFalseWhenHeaderIsNotSet()
{ {
$message = $this->getMockForAbstractClass('\WellRESTed\Message\Message'); $message = $this->getMockForAbstractClass('\WellRESTed\Message\Message');
$this->assertFalse($message->hasHeader("Content-type")); $this->assertFalse($message->hasHeader("Content-type"));
} }
/**
* @covers ::getHeaders
*/
public function testGetHeadersReturnOriginalHeaderNamesAsKeys() public function testGetHeadersReturnOriginalHeaderNamesAsKeys()
{ {
$message = $this->getMockForAbstractClass('\WellRESTed\Message\Message'); $message = $this->getMockForAbstractClass('\WellRESTed\Message\Message');
@ -251,9 +183,6 @@ class MessageTest extends \PHPUnit_Framework_TestCase
$this->assertEquals(0, $countUnmatched); $this->assertEquals(0, $countUnmatched);
} }
/**
* @covers ::getHeaders
*/
public function testGetHeadersReturnOriginalHeaderNamesAndValues() public function testGetHeadersReturnOriginalHeaderNamesAndValues()
{ {
$message = $this->getMockForAbstractClass('\WellRESTed\Message\Message'); $message = $this->getMockForAbstractClass('\WellRESTed\Message\Message');
@ -284,20 +213,12 @@ class MessageTest extends \PHPUnit_Framework_TestCase
// ------------------------------------------------------------------------ // ------------------------------------------------------------------------
// Body // Body
/**
* @covers ::getBody
* @uses WellRESTed\Message\NullStream
*/
public function testGetBodyReturnsEmptyStreamByDefault() public function testGetBodyReturnsEmptyStreamByDefault()
{ {
$message = $this->getMockForAbstractClass('\WellRESTed\Message\Message'); $message = $this->getMockForAbstractClass('\WellRESTed\Message\Message');
$this->assertEquals("", (string) $message->getBody()); $this->assertEquals("", (string) $message->getBody());
} }
/**
* @covers ::getBody
* @covers ::withBody
*/
public function testGetBodyReturnsAttachedStream() public function testGetBodyReturnsAttachedStream()
{ {
$stream = $this->prophesize('\Psr\Http\Message\StreamInterface'); $stream = $this->prophesize('\Psr\Http\Message\StreamInterface');

View File

@ -5,15 +5,11 @@ namespace WellRESTed\Test\Message;
use WellRESTed\Message\NullStream; use WellRESTed\Message\NullStream;
/** /**
* @coversDefaultClass WellRESTed\Message\NullStream * @covers WellRESTed\Message\NullStream
* @uses WellRESTed\Message\NullStream
* @group message * @group message
*/ */
class NullStreamTest extends \PHPUnit_Framework_TestCase class NullStreamTest extends \PHPUnit_Framework_TestCase
{ {
/**
* @covers ::__toString()
*/
public function testCastsToString() public function testCastsToString()
{ {
$stream = new NullStream(); $stream = new NullStream();
@ -27,129 +23,87 @@ class NullStreamTest extends \PHPUnit_Framework_TestCase
$this->assertTrue(true); // Asserting no exception occured. $this->assertTrue(true); // Asserting no exception occured.
} }
/**
* @covers ::detach()
*/
public function testDetachReturnsNull() public function testDetachReturnsNull()
{ {
$stream = new \WellRESTed\Message\NullStream(); $stream = new \WellRESTed\Message\NullStream();
$this->assertNull($stream->detach()); $this->assertNull($stream->detach());
} }
/**
* @covers ::getSize
*/
public function testSizeReturnsZero() public function testSizeReturnsZero()
{ {
$stream = new \WellRESTed\Message\NullStream(); $stream = new \WellRESTed\Message\NullStream();
$this->assertEquals(0, $stream->getSize()); $this->assertEquals(0, $stream->getSize());
} }
/**
* @covers ::tell
*/
public function testTellReturnsZero() public function testTellReturnsZero()
{ {
$stream = new \WellRESTed\Message\NullStream(); $stream = new \WellRESTed\Message\NullStream();
$this->assertEquals(0, $stream->tell()); $this->assertEquals(0, $stream->tell());
} }
/**
* @covers ::eof
*/
public function testEofReturnsTrue() public function testEofReturnsTrue()
{ {
$stream = new \WellRESTed\Message\NullStream(); $stream = new \WellRESTed\Message\NullStream();
$this->assertTrue($stream->eof()); $this->assertTrue($stream->eof());
} }
/**
* @covers ::isSeekable
*/
public function testIsSeekableReturnsFalse() public function testIsSeekableReturnsFalse()
{ {
$stream = new \WellRESTed\Message\NullStream(); $stream = new \WellRESTed\Message\NullStream();
$this->assertFalse($stream->isSeekable()); $this->assertFalse($stream->isSeekable());
} }
/** /** @expectedException \RuntimeException */
* @covers ::seek
* @expectedException \RuntimeException
*/
public function testSeekReturnsFalse() public function testSeekReturnsFalse()
{ {
$stream = new NullStream(); $stream = new NullStream();
$stream->seek(10); $stream->seek(10);
} }
/** /** @expectedException \RuntimeException */
* @covers ::rewind
* @expectedException \RuntimeException
*/
public function testRewindThrowsException() public function testRewindThrowsException()
{ {
$stream = new \WellRESTed\Message\NullStream(); $stream = new \WellRESTed\Message\NullStream();
$stream->rewind(); $stream->rewind();
} }
/**
* @covers ::isWritable
*/
public function testIsWritableReturnsFalse() public function testIsWritableReturnsFalse()
{ {
$stream = new NullStream(); $stream = new NullStream();
$this->assertFalse($stream->isWritable()); $this->assertFalse($stream->isWritable());
} }
/** /** @expectedException \RuntimeException */
* @covers ::write
* @expectedException \RuntimeException
*/
public function testWriteThrowsException() public function testWriteThrowsException()
{ {
$stream = new \WellRESTed\Message\NullStream(); $stream = new \WellRESTed\Message\NullStream();
$stream->write(""); $stream->write("");
} }
/**
* @covers ::isReadable
*/
public function testIsReadableReturnsTrue() public function testIsReadableReturnsTrue()
{ {
$stream = new \WellRESTed\Message\NullStream(); $stream = new \WellRESTed\Message\NullStream();
$this->assertTrue($stream->isReadable()); $this->assertTrue($stream->isReadable());
} }
/**
* @covers ::read
*/
public function testReadReturnsEmptyString() public function testReadReturnsEmptyString()
{ {
$stream = new \WellRESTed\Message\NullStream(); $stream = new \WellRESTed\Message\NullStream();
$this->assertEquals("", $stream->read(100)); $this->assertEquals("", $stream->read(100));
} }
/**
* @covers ::getContents
*/
public function testGetContentsReturnsEmptyString() public function testGetContentsReturnsEmptyString()
{ {
$stream = new NullStream(); $stream = new NullStream();
$this->assertEquals("", $stream->getContents()); $this->assertEquals("", $stream->getContents());
} }
/**
* @covers ::getMetadata
*/
public function testGetMetadataReturnsNull() public function testGetMetadataReturnsNull()
{ {
$stream = new \WellRESTed\Message\NullStream(); $stream = new \WellRESTed\Message\NullStream();
$this->assertNull($stream->getMetadata()); $this->assertNull($stream->getMetadata());
} }
/**
* @covers ::getMetadata
*/
public function testGetMetadataReturnsNullWithKey() public function testGetMetadataReturnsNullWithKey()
{ {
$stream = new \WellRESTed\Message\NullStream(); $stream = new \WellRESTed\Message\NullStream();

View File

@ -2,16 +2,12 @@
namespace WellRESTed\Test\Unit\Message; namespace WellRESTed\Test\Unit\Message;
use WellRESTed\Message\NullStream;
use WellRESTed\Message\Request; use WellRESTed\Message\Request;
use WellRESTed\Message\Uri; use WellRESTed\Message\Uri;
/** /**
* @coversDefaultClass WellRESTed\Message\Request * @covers WellRESTed\Message\Request
* @uses WellRESTed\Message\Request
* @uses WellRESTed\Message\Request
* @uses WellRESTed\Message\Message
* @uses WellRESTed\Message\HeaderCollection
* @uses WellRESTed\Message\Uri
* @group message * @group message
*/ */
class RequestTest extends \PHPUnit_Framework_TestCase class RequestTest extends \PHPUnit_Framework_TestCase
@ -19,29 +15,19 @@ class RequestTest extends \PHPUnit_Framework_TestCase
// ------------------------------------------------------------------------ // ------------------------------------------------------------------------
// Construction // Construction
/** public function testCreatesInstanceWithNoParameters()
* @covers ::__construct
*/
public function testCreatesInstance()
{ {
$request = new Request(); $request = new Request();
$this->assertNotNull($request); $this->assertNotNull($request);
} }
/**
* @covers ::__construct
*/
public function testCreatesInstanceWithUri() public function testCreatesInstanceWithUri()
{ {
$uri = $this->prophesize('Psr\Http\Message\UriInterface'); $uri = new Uri();
$uri = $uri->reveal();
$request = new Request($uri); $request = new Request($uri);
$this->assertSame($uri, $request->getUri()); $this->assertSame($uri, $request->getUri());
} }
/**
* @covers ::__construct
*/
public function testCreatesInstanceWithMethod() public function testCreatesInstanceWithMethod()
{ {
$method = "POST"; $method = "POST";
@ -49,9 +35,6 @@ class RequestTest extends \PHPUnit_Framework_TestCase
$this->assertSame($method, $request->getMethod()); $this->assertSame($method, $request->getMethod());
} }
/**
* @covers ::__construct
*/
public function testSetsHeadersOnConstruction() public function testSetsHeadersOnConstruction()
{ {
$request = new Request(null, null, [ $request = new Request(null, null, [
@ -60,22 +43,16 @@ class RequestTest extends \PHPUnit_Framework_TestCase
$this->assertEquals(["bar","baz"], $request->getHeader("X-foo")); $this->assertEquals(["bar","baz"], $request->getHeader("X-foo"));
} }
/**
* @covers ::__construct
*/
public function testSetsBodyOnConstruction() public function testSetsBodyOnConstruction()
{ {
$body = $this->prophesize('\Psr\Http\Message\StreamInterface'); $body = new NullStream();
$request = new Request(null, null, [], $body->reveal()); $request = new Request(null, null, [], $body);
$this->assertSame($body->reveal(), $request->getBody()); $this->assertSame($body, $request->getBody());
} }
// ------------------------------------------------------------------------ // ------------------------------------------------------------------------
// Request Target // Request Target
/**
* @covers ::getRequestTarget
*/
public function testGetRequestTargetPrefersExplicitRequestTarget() public function testGetRequestTargetPrefersExplicitRequestTarget()
{ {
$request = new Request(); $request = new Request();
@ -83,34 +60,20 @@ class RequestTest extends \PHPUnit_Framework_TestCase
$this->assertEquals("*", $request->getRequestTarget()); $this->assertEquals("*", $request->getRequestTarget());
} }
/**
* @covers ::getRequestTarget
*/
public function testGetRequestTargetUsesOriginFormOfUri() public function testGetRequestTargetUsesOriginFormOfUri()
{ {
$uri = $this->prophesize('\Psr\Http\Message\UriInterface'); $uri = new Uri('/my/path?cat=Molly&dog=Bear');
$uri->getHost()->willReturn("");
$uri->getPath()->willReturn("/my/path");
$uri->getQuery()->willReturn("cat=Molly&dog=Bear");
$request = new Request(); $request = new Request();
$request = $request->withUri($uri->reveal()); $request = $request->withUri($uri);
$this->assertEquals("/my/path?cat=Molly&dog=Bear", $request->getRequestTarget()); $this->assertEquals("/my/path?cat=Molly&dog=Bear", $request->getRequestTarget());
} }
/**
* @covers ::getRequestTarget
*/
public function testGetRequestTargetReturnsSlashByDefault() public function testGetRequestTargetReturnsSlashByDefault()
{ {
$request = new Request(); $request = new Request();
$this->assertEquals("/", $request->getRequestTarget()); $this->assertEquals("/", $request->getRequestTarget());
} }
/**
* @covers ::withRequestTarget
* @covers ::getRequestTarget
*/
public function testWithRequestTargetCreatesNewInstance() public function testWithRequestTargetCreatesNewInstance()
{ {
$request = new Request(); $request = new Request();
@ -121,20 +84,12 @@ class RequestTest extends \PHPUnit_Framework_TestCase
// ------------------------------------------------------------------------ // ------------------------------------------------------------------------
// Method // Method
/**
* @covers ::getMethod
*/
public function testGetMethodReturnsGetByDefault() public function testGetMethodReturnsGetByDefault()
{ {
$request = new Request(); $request = new Request();
$this->assertEquals("GET", $request->getMethod()); $this->assertEquals("GET", $request->getMethod());
} }
/**
* @covers ::withMethod
* @covers ::getValidatedMethod
* @covers ::getMethod
*/
public function testWithMethodCreatesNewInstance() public function testWithMethodCreatesNewInstance()
{ {
$request = new Request(); $request = new Request();
@ -143,8 +98,6 @@ class RequestTest extends \PHPUnit_Framework_TestCase
} }
/** /**
* @covers ::withMethod
* @covers ::getValidatedMethod
* @dataProvider invalidMethodProvider * @dataProvider invalidMethodProvider
* @expectedException \InvalidArgumentException * @expectedException \InvalidArgumentException
*/ */
@ -166,9 +119,6 @@ class RequestTest extends \PHPUnit_Framework_TestCase
// ------------------------------------------------------------------------ // ------------------------------------------------------------------------
// Request URI // Request URI
/**
* @covers ::getUri
*/
public function testGetUriReturnsEmptyUriByDefault() public function testGetUriReturnsEmptyUriByDefault()
{ {
$request = new Request(); $request = new Request();
@ -176,30 +126,18 @@ class RequestTest extends \PHPUnit_Framework_TestCase
$this->assertEquals($uri, $request->getUri()); $this->assertEquals($uri, $request->getUri());
} }
/**
* @covers ::withUri
* @covers ::getUri
*/
public function testWithUriCreatesNewInstance() public function testWithUriCreatesNewInstance()
{ {
$uri = $this->prophesize('\Psr\Http\Message\UriInterface'); $uri = new Uri();
$uri = $uri->reveal();
$request = new Request(); $request = new Request();
$request = $request->withUri($uri); $request = $request->withUri($uri);
$this->assertSame($uri, $request->getUri()); $this->assertSame($uri, $request->getUri());
} }
/**
* @covers ::__clone
*/
public function testWithUriPreservesOriginalRequest() public function testWithUriPreservesOriginalRequest()
{ {
$uri1 = $this->prophesize('\Psr\Http\Message\UriInterface'); $uri1 = new Uri();
$uri1 = $uri1->reveal(); $uri2 = new Uri();
$uri2 = $this->prophesize('\Psr\Http\Message\UriInterface');
$uri2 = $uri2->reveal();
$request1 = new Request(); $request1 = new Request();
$request1 = $request1->withUri($uri1); $request1 = $request1->withUri($uri1);
@ -211,75 +149,55 @@ class RequestTest extends \PHPUnit_Framework_TestCase
$this->assertNotEquals($request1->getHeader("Accept"), $request2->getHeader("Accept")); $this->assertNotEquals($request1->getHeader("Accept"), $request2->getHeader("Accept"));
} }
/**
* @covers ::withUri
*/
public function testWithUriUpdatesHostHeader() public function testWithUriUpdatesHostHeader()
{ {
$hostname = "bar.com"; $hostname = "bar.com";
$uri = $this->prophesize('\Psr\Http\Message\UriInterface'); $uri = new uri("http://$hostname");
$uri->getHost()->willReturn($hostname);
$request = new Request(); $request = new Request();
$request = $request->withHeader("Host", "foo.com"); $request = $request->withHeader("Host", "foo.com");
$request = $request->withUri($uri->reveal()); $request = $request->withUri($uri);
$this->assertSame([$hostname], $request->getHeader("Host")); $this->assertSame([$hostname], $request->getHeader("Host"));
} }
/**
* @covers ::withUri
*/
public function testWithUriDoesNotUpdatesHostHeaderWhenUriHasNoHost() public function testWithUriDoesNotUpdatesHostHeaderWhenUriHasNoHost()
{ {
$hostname = "foo.com"; $hostname = "foo.com";
$uri = $this->prophesize('\Psr\Http\Message\UriInterface'); $uri = new Uri();
$uri->getHost()->willReturn("");
$request = new Request(); $request = new Request();
$request = $request->withHeader("Host", $hostname); $request = $request->withHeader("Host", $hostname);
$request = $request->withUri($uri->reveal()); $request = $request->withUri($uri);
$this->assertSame([$hostname], $request->getHeader("Host")); $this->assertSame([$hostname], $request->getHeader("Host"));
} }
/**
* @covers ::withUri
*/
public function testPreserveHostUpdatesHostHeaderWhenHeaderIsOriginallyMissing() public function testPreserveHostUpdatesHostHeaderWhenHeaderIsOriginallyMissing()
{ {
$hostname = "foo.com"; $hostname = "foo.com";
$uri = $this->prophesize('\Psr\Http\Message\UriInterface'); $uri = new uri("http://$hostname");
$uri->getHost()->willReturn($hostname);
$request = new Request(); $request = new Request();
$request = $request->withUri($uri->reveal(), true); $request = $request->withUri($uri, true);
$this->assertSame([$hostname], $request->getHeader("Host")); $this->assertSame([$hostname], $request->getHeader("Host"));
} }
/**
* @covers ::withUri
*/
public function testPreserveHostDoesNotUpdatesWhenBothAreMissingHosts() public function testPreserveHostDoesNotUpdatesWhenBothAreMissingHosts()
{ {
$uri = $this->prophesize('\Psr\Http\Message\UriInterface'); $uri = new Uri();
$uri->getHost()->willReturn("");
$request = new Request(); $request = new Request();
$request = $request->withUri($uri->reveal(), true); $request = $request->withUri($uri, true);
$this->assertSame([], $request->getHeader("Host")); $this->assertSame([], $request->getHeader("Host"));
} }
/**
* @covers ::withUri
*/
public function testPreserveHostDoesNotUpdateHostHeader() public function testPreserveHostDoesNotUpdateHostHeader()
{ {
$hostname = "foo.com"; $hostname = "foo.com";
$uri = $this->prophesize('\Psr\Http\Message\UriInterface'); $uri = new uri("http://bar.com");
$uri->getHost()->willReturn("bar.com");
$request = new Request(); $request = new Request();
$request = $request->withHeader("Host", $hostname); $request = $request->withHeader("Host", $hostname);
$request = $request->withUri($uri->reveal(), true); $request = $request->withUri($uri, true);
$this->assertSame([$hostname], $request->getHeader("Host")); $this->assertSame([$hostname], $request->getHeader("Host"));
} }
} }

View File

@ -2,13 +2,11 @@
namespace WellRESTed\Test\Unit\Message; namespace WellRESTed\Test\Unit\Message;
use WellRESTed\Message\NullStream;
use WellRESTed\Message\Response; use WellRESTed\Message\Response;
/** /**
* @coversDefaultClass WellRESTed\Message\Response * @covers WellRESTed\Message\Response
* @uses WellRESTed\Message\Response
* @uses WellRESTed\Message\Message
* @uses WellRESTed\Message\HeaderCollection
* @group message * @group message
*/ */
class ResponseTest extends \PHPUnit_Framework_TestCase class ResponseTest extends \PHPUnit_Framework_TestCase
@ -16,18 +14,12 @@ class ResponseTest extends \PHPUnit_Framework_TestCase
// ------------------------------------------------------------------------ // ------------------------------------------------------------------------
// Construction // Construction
/**
* @covers ::__construct
*/
public function testSetsStatusCodeOnConstruction() public function testSetsStatusCodeOnConstruction()
{ {
$response = new Response(200); $response = new Response(200);
$this->assertSame(200, $response->getStatusCode()); $this->assertSame(200, $response->getStatusCode());
} }
/**
* @covers ::__construct
*/
public function testSetsHeadersOnConstruction() public function testSetsHeadersOnConstruction()
{ {
$response = new Response(200, [ $response = new Response(200, [
@ -36,24 +28,16 @@ class ResponseTest extends \PHPUnit_Framework_TestCase
$this->assertEquals(["bar","baz"], $response->getHeader("X-foo")); $this->assertEquals(["bar","baz"], $response->getHeader("X-foo"));
} }
/**
* @covers ::__construct
*/
public function testSetsBodyOnConstruction() public function testSetsBodyOnConstruction()
{ {
$body = $this->prophesize('\Psr\Http\Message\StreamInterface'); $body = new NullStream();
$response = new Response(200, [], $body->reveal()); $response = new Response(200, [], $body);
$this->assertSame($body->reveal(), $response->getBody()); $this->assertSame($body, $response->getBody());
} }
// ------------------------------------------------------------------------ // ------------------------------------------------------------------------
// Status and Reason Phrase // Status and Reason Phrase
/**
* @covers ::withStatus
* @covers ::getStatusCode
* @covers ::getDefaultReasonPhraseForStatusCode
*/
public function testCreatesNewInstanceWithStatusCode() public function testCreatesNewInstanceWithStatusCode()
{ {
$response = new Response(); $response = new Response();
@ -61,12 +45,7 @@ class ResponseTest extends \PHPUnit_Framework_TestCase
$this->assertEquals(200, $copy->getStatusCode()); $this->assertEquals(200, $copy->getStatusCode());
} }
/** /** @dataProvider statusProvider */
* @covers ::withStatus
* @covers ::getReasonPhrase
* @covers ::getDefaultReasonPhraseForStatusCode
* @dataProvider statusProvider
*/
public function testCreatesNewInstanceWithReasonPhrase($code, $reasonPhrase, $expected) public function testCreatesNewInstanceWithReasonPhrase($code, $reasonPhrase, $expected)
{ {
$response = new Response(); $response = new Response();
@ -119,10 +98,6 @@ class ResponseTest extends \PHPUnit_Framework_TestCase
]; ];
} }
/**
* @covers ::withStatus
* @covers ::getStatusCode
*/
public function testWithStatusCodePreservesOriginalResponse() public function testWithStatusCodePreservesOriginalResponse()
{ {
$response1 = new Response(); $response1 = new Response();

View File

@ -2,19 +2,13 @@
namespace WellRESTed\Test\Unit\Message; namespace WellRESTed\Test\Unit\Message;
use WellRESTed\Message\NullStream;
use WellRESTed\Message\ServerRequest; use WellRESTed\Message\ServerRequest;
use WellRESTed\Message\UploadedFile; use WellRESTed\Message\UploadedFile;
use WellRESTed\Message\Uri; use WellRESTed\Message\Uri;
/** /**
* @coversDefaultClass WellRESTed\Message\ServerRequest * @covers WellRESTed\Message\ServerRequest
* @uses WellRESTed\Message\ServerRequest
* @uses WellRESTed\Message\Request
* @uses WellRESTed\Message\Message
* @uses WellRESTed\Message\HeaderCollection
* @uses WellRESTed\Message\Stream
* @uses WellRESTed\Message\UploadedFile
* @uses WellRESTed\Message\Uri
* @group message * @group message
*/ */
class ServerRequestTest extends \PHPUnit_Framework_TestCase class ServerRequestTest extends \PHPUnit_Framework_TestCase
@ -22,22 +16,7 @@ class ServerRequestTest extends \PHPUnit_Framework_TestCase
// ------------------------------------------------------------------------ // ------------------------------------------------------------------------
// Construction and Marshalling // Construction and Marshalling
/** /** @preserveGlobalState disabled */
* @covers ::__construct
*/
public function testCreatesInstance()
{
$request = new ServerRequest();
$this->assertNotNull($request);
}
/**
* @covers ::getServerRequest
* @covers ::getServerRequestHeaders
* @covers ::readFromServerRequest
* @covers ::getStreamForBody
* @preserveGlobalState disabled
*/
public function testGetServerRequestReadsFromRequest() public function testGetServerRequestReadsFromRequest()
{ {
$_SERVER = [ $_SERVER = [
@ -63,7 +42,6 @@ class ServerRequestTest extends \PHPUnit_Framework_TestCase
// Marshalling Request Information // Marshalling Request Information
/** /**
* @covers ::readFromServerRequest
* @preserveGlobalState disabled * @preserveGlobalState disabled
* @dataProvider protocolVersionProvider * @dataProvider protocolVersionProvider
*/ */
@ -89,7 +67,6 @@ class ServerRequestTest extends \PHPUnit_Framework_TestCase
} }
/** /**
* @covers ::readFromServerRequest
* @preserveGlobalState disabled * @preserveGlobalState disabled
* @dataProvider methodProvider * @dataProvider methodProvider
*/ */
@ -116,7 +93,6 @@ class ServerRequestTest extends \PHPUnit_Framework_TestCase
} }
/** /**
* @covers ::readFromServerRequest
* @preserveGlobalState disabled * @preserveGlobalState disabled
* @dataProvider requestTargetProvider * @dataProvider requestTargetProvider
*/ */
@ -140,29 +116,22 @@ class ServerRequestTest extends \PHPUnit_Framework_TestCase
]; ];
} }
/** /** @depends testGetServerRequestReadsFromRequest */
* @covers ::getHeader
* @depends testGetServerRequestReadsFromRequest
*/
public function testGetServerRequestReadsHeaders($request) public function testGetServerRequestReadsHeaders($request)
{ {
/** @var ServerRequest $request */ /** @var ServerRequest $request */
$this->assertEquals(["application/json"], $request->getHeader("Accept")); $this->assertEquals(["application/json"], $request->getHeader("Accept"));
} }
/**
* @covers ::getBody
*/
public function testGetServerRequestReadsBody() public function testGetServerRequestReadsBody()
{ {
$body = $this->prophesize('Psr\Http\Message\StreamInterface'); $body = new NullStream();
$request = $this->getMockBuilder('WellRESTed\Message\ServerRequest') $request = $this->getMockBuilder('WellRESTed\Message\ServerRequest')
->setMethods(["getStreamForBody"]) ->setMethods(["getStreamForBody"])
->getMock(); ->getMock();
$request->expects($this->any()) $request->expects($this->any())
->method("getStreamForBody") ->method("getStreamForBody")
->will($this->returnValue($body->reveal())); ->will($this->returnValue($body));
$called = false; $called = false;
$callReadFromServerRequest = function () use (&$called) { $callReadFromServerRequest = function () use (&$called) {
@ -172,14 +141,10 @@ class ServerRequestTest extends \PHPUnit_Framework_TestCase
$callReadFromServerRequest = $callReadFromServerRequest->bindTo($request, $request); $callReadFromServerRequest = $callReadFromServerRequest->bindTo($request, $request);
$callReadFromServerRequest(); $callReadFromServerRequest();
$this->assertSame($body->reveal(), $request->getBody()); $this->assertSame($body, $request->getBody());
} }
/** /**
* @covers ::getServerRequest
* @covers ::getServerRequestHeaders
* @covers ::readFromServerRequest
* @covers ::readUri
* @preserveGlobalState disabled * @preserveGlobalState disabled
* @dataProvider uriProvider * @dataProvider uriProvider
*/ */
@ -226,30 +191,21 @@ class ServerRequestTest extends \PHPUnit_Framework_TestCase
// ------------------------------------------------------------------------ // ------------------------------------------------------------------------
// Marshalling ServerRequest Information // Marshalling ServerRequest Information
/** /** @depends testGetServerRequestReadsFromRequest */
* @covers ::getServerParams
* @depends testGetServerRequestReadsFromRequest
*/
public function testGetServerRequestReadsServerParams($request) public function testGetServerRequestReadsServerParams($request)
{ {
/** @var ServerRequest $request */ /** @var ServerRequest $request */
$this->assertEquals("localhost", $request->getServerParams()["HTTP_HOST"]); $this->assertEquals("localhost", $request->getServerParams()["HTTP_HOST"]);
} }
/** /** @depends testGetServerRequestReadsFromRequest */
* @covers ::getCookieParams
* @depends testGetServerRequestReadsFromRequest
*/
public function testGetServerRequestReadsCookieParams($request) public function testGetServerRequestReadsCookieParams($request)
{ {
/** @var ServerRequest $request */ /** @var ServerRequest $request */
$this->assertEquals("Molly", $request->getCookieParams()["cat"]); $this->assertEquals("Molly", $request->getCookieParams()["cat"]);
} }
/** /** @depends testGetServerRequestReadsFromRequest */
* @covers ::getQueryParams
* @depends testGetServerRequestReadsFromRequest
*/
public function testGetServerRequestReadsQueryParams($request) public function testGetServerRequestReadsQueryParams($request)
{ {
/** @var ServerRequest $request */ /** @var ServerRequest $request */
@ -257,10 +213,6 @@ class ServerRequestTest extends \PHPUnit_Framework_TestCase
} }
/** /**
* @covers ::getServerRequest
* @covers ::readUploadedFiles
* @covers ::getUploadedFiles
* @covers ::addUploadedFilesToBranch
* @preserveGlobalState disabled * @preserveGlobalState disabled
* @dataProvider uploadedFileProvider * @dataProvider uploadedFileProvider
*/ */
@ -364,8 +316,6 @@ class ServerRequestTest extends \PHPUnit_Framework_TestCase
} }
/** /**
* @covers ::getServerRequest
* @covers ::getParsedBody
* @preserveGlobalState disabled * @preserveGlobalState disabled
* @dataProvider formContentTypeProvider * @dataProvider formContentTypeProvider
*/ */
@ -392,10 +342,7 @@ class ServerRequestTest extends \PHPUnit_Framework_TestCase
]; ];
} }
/** /** @depends testGetServerRequestReadsFromRequest */
* @covers ::getAttribute
* @depends testGetServerRequestReadsFromRequest
*/
public function testGetServerRequestProvidesAttributesIfPassed($request) public function testGetServerRequestProvidesAttributesIfPassed($request)
{ {
/** @var ServerRequest $request */ /** @var ServerRequest $request */
@ -405,9 +352,6 @@ class ServerRequestTest extends \PHPUnit_Framework_TestCase
// ------------------------------------------------------------------------ // ------------------------------------------------------------------------
// Server Params // Server Params
/**
* @covers ::getServerParams
*/
public function testGetServerParamsReturnsEmptyArrayByDefault() public function testGetServerParamsReturnsEmptyArrayByDefault()
{ {
$request = new ServerRequest(); $request = new ServerRequest();
@ -417,19 +361,13 @@ class ServerRequestTest extends \PHPUnit_Framework_TestCase
// ------------------------------------------------------------------------ // ------------------------------------------------------------------------
// Cookies // Cookies
/**
* @covers ::getCookieParams
*/
public function testGetCookieParamsReturnsEmptyArrayByDefault() public function testGetCookieParamsReturnsEmptyArrayByDefault()
{ {
$request = new ServerRequest(); $request = new ServerRequest();
$this->assertEquals([], $request->getCookieParams()); $this->assertEquals([], $request->getCookieParams());
} }
/** /** @depends testGetServerRequestReadsFromRequest */
* @covers ::withCookieParams
* @depends testGetServerRequestReadsFromRequest
*/
public function testWithCookieParamsCreatesNewInstance($request1) public function testWithCookieParamsCreatesNewInstance($request1)
{ {
/** @var ServerRequest $request1 */ /** @var ServerRequest $request1 */
@ -442,19 +380,13 @@ class ServerRequestTest extends \PHPUnit_Framework_TestCase
// ------------------------------------------------------------------------ // ------------------------------------------------------------------------
// Query // Query
/**
* @covers ::getQueryParams
*/
public function testGetQueryParamsReturnsEmptyArrayByDefault() public function testGetQueryParamsReturnsEmptyArrayByDefault()
{ {
$request = new ServerRequest(); $request = new ServerRequest();
$this->assertEquals([], $request->getQueryParams()); $this->assertEquals([], $request->getQueryParams());
} }
/** /** @depends testGetServerRequestReadsFromRequest */
* @covers ::withQueryParams
* @depends testGetServerRequestReadsFromRequest
*/
public function testWithQueryParamsCreatesNewInstance($request1) public function testWithQueryParamsCreatesNewInstance($request1)
{ {
/** @var ServerRequest $request1 */ /** @var ServerRequest $request1 */
@ -467,19 +399,13 @@ class ServerRequestTest extends \PHPUnit_Framework_TestCase
// ------------------------------------------------------------------------ // ------------------------------------------------------------------------
// Uploaded Files // Uploaded Files
/**
* @covers ::getUploadedFiles
*/
public function testGetUploadedFilesReturnsEmptyArrayByDefault() public function testGetUploadedFilesReturnsEmptyArrayByDefault()
{ {
$request = new ServerRequest(); $request = new ServerRequest();
$this->assertEquals([], $request->getUploadedFiles()); $this->assertEquals([], $request->getUploadedFiles());
} }
/** /** @preserveGlobalState disabled */
* @covers ::getUploadedFiles
* @preserveGlobalState disabled
*/
public function testGetUploadedFilesReturnsEmptyArrayWhenNoFilesAreUploaded() public function testGetUploadedFilesReturnsEmptyArrayWhenNoFilesAreUploaded()
{ {
$_SERVER = [ $_SERVER = [
@ -492,11 +418,6 @@ class ServerRequestTest extends \PHPUnit_Framework_TestCase
$this->assertSame([], $request->getUploadedFiles()); $this->assertSame([], $request->getUploadedFiles());
} }
/**
* @covers ::withUploadedFiles
* @covers ::isValidUploadedFilesBranch
* @covers ::isValidUploadedFilesTree
*/
public function testWithUploadedFilesCreatesNewInstance() public function testWithUploadedFilesCreatesNewInstance()
{ {
$uploadedFiles = [ $uploadedFiles = [
@ -508,12 +429,7 @@ class ServerRequestTest extends \PHPUnit_Framework_TestCase
$this->assertNotSame($request2, $request1); $this->assertNotSame($request2, $request1);
} }
/** /** @dataProvider validUploadedFilesProvider */
* @covers ::withUploadedFiles
* @covers ::isValidUploadedFilesTree
* @covers ::isValidUploadedFilesBranch
* @dataProvider validUploadedFilesProvider
*/
public function testWithUploadedFilesStoresPassedUploadedFiles($uploadedFiles) public function testWithUploadedFilesStoresPassedUploadedFiles($uploadedFiles)
{ {
$request = new ServerRequest(); $request = new ServerRequest();
@ -545,9 +461,6 @@ class ServerRequestTest extends \PHPUnit_Framework_TestCase
} }
/** /**
* @covers ::withUploadedFiles
* @covers ::isValidUploadedFilesTree
* @covers ::isValidUploadedFilesBranch
* @expectedException \InvalidArgumentException * @expectedException \InvalidArgumentException
* @dataProvider invalidUploadedFilesProvider * @dataProvider invalidUploadedFilesProvider
*/ */
@ -621,19 +534,13 @@ class ServerRequestTest extends \PHPUnit_Framework_TestCase
// ------------------------------------------------------------------------ // ------------------------------------------------------------------------
// Parsed Body // Parsed Body
/**
* @covers ::getParsedBody
*/
public function testGetParsedBodyReturnsNullByDefault() public function testGetParsedBodyReturnsNullByDefault()
{ {
$request = new ServerRequest(); $request = new ServerRequest();
$this->assertNull($request->getParsedBody()); $this->assertNull($request->getParsedBody());
} }
/** /** @depends testGetServerRequestReadsFromRequest */
* @covers ::withParsedBody
* @depends testGetServerRequestReadsFromRequest
*/
public function testWithParsedBodyCreatesNewInstance($request1) public function testWithParsedBodyCreatesNewInstance($request1)
{ {
/** @var ServerRequest $request1 */ /** @var ServerRequest $request1 */
@ -648,7 +555,6 @@ class ServerRequestTest extends \PHPUnit_Framework_TestCase
} }
/** /**
* @covers ::withParsedBody
* @expectedException \InvalidArgumentException * @expectedException \InvalidArgumentException
* @dataProvider invalidParsedBodyProvider * @dataProvider invalidParsedBodyProvider
*/ */
@ -666,9 +572,6 @@ class ServerRequestTest extends \PHPUnit_Framework_TestCase
]; ];
} }
/**
* @covers ::__clone
*/
public function testCloneMakesDeepCopiesOfParsedBody() public function testCloneMakesDeepCopiesOfParsedBody()
{ {
$body = (object) [ $body = (object) [
@ -688,18 +591,12 @@ class ServerRequestTest extends \PHPUnit_Framework_TestCase
// ------------------------------------------------------------------------ // ------------------------------------------------------------------------
// Attributes // Attributes
/**
* @covers ::getAttributes
*/
public function testGetAttributesReturnsEmptyArrayByDefault() public function testGetAttributesReturnsEmptyArrayByDefault()
{ {
$request = new ServerRequest(); $request = new ServerRequest();
$this->assertEquals([], $request->getAttributes()); $this->assertEquals([], $request->getAttributes());
} }
/**
* @covers ::getAttributes
*/
public function testGetAttributesReturnsAllAttributes() public function testGetAttributesReturnsAllAttributes()
{ {
$request = new ServerRequest(); $request = new ServerRequest();
@ -712,19 +609,12 @@ class ServerRequestTest extends \PHPUnit_Framework_TestCase
$this->assertEquals($expected, $request->getAttributes()); $this->assertEquals($expected, $request->getAttributes());
} }
/**
* @covers ::getAttribute
*/
public function testGetAttributeReturnsDefaultIfNotSet() public function testGetAttributeReturnsDefaultIfNotSet()
{ {
$request = new ServerRequest(); $request = new ServerRequest();
$this->assertEquals("Oscar", $request->getAttribute("cat", "Oscar")); $this->assertEquals("Oscar", $request->getAttribute("cat", "Oscar"));
} }
/**
* @covers ::withAttribute
* @covers ::getAttribute
*/
public function testWithAttributeCreatesNewInstance() public function testWithAttributeCreatesNewInstance()
{ {
$request = new ServerRequest(); $request = new ServerRequest();
@ -732,9 +622,6 @@ class ServerRequestTest extends \PHPUnit_Framework_TestCase
$this->assertEquals("Molly", $request->getAttribute("cat")); $this->assertEquals("Molly", $request->getAttribute("cat"));
} }
/**
* @covers ::withAttribute
*/
public function testWithAttributePreserversOtherAttributes() public function testWithAttributePreserversOtherAttributes()
{ {
$request = new ServerRequest(); $request = new ServerRequest();
@ -747,9 +634,6 @@ class ServerRequestTest extends \PHPUnit_Framework_TestCase
$this->assertEquals($expected, $request->getAttributes()); $this->assertEquals($expected, $request->getAttributes());
} }
/**
* @covers ::withoutAttribute
*/
public function testWithoutAttributeCreatesNewInstance() public function testWithoutAttributeCreatesNewInstance()
{ {
$request = new ServerRequest(); $request = new ServerRequest();
@ -757,9 +641,6 @@ class ServerRequestTest extends \PHPUnit_Framework_TestCase
$this->assertNotEquals($request, $request->withoutAttribute("cat")); $this->assertNotEquals($request, $request->withoutAttribute("cat"));
} }
/**
* @covers ::withoutAttribute
*/
public function testWithoutAttributeRemovesAttribute() public function testWithoutAttributeRemovesAttribute()
{ {
$request = new ServerRequest(); $request = new ServerRequest();
@ -768,9 +649,6 @@ class ServerRequestTest extends \PHPUnit_Framework_TestCase
$this->assertEquals("Oscar", $request->getAttribute("cat", "Oscar")); $this->assertEquals("Oscar", $request->getAttribute("cat", "Oscar"));
} }
/**
* @covers ::withoutAttribute
*/
public function testWithoutAttributePreservesOtherAttributes() public function testWithoutAttributePreservesOtherAttributes()
{ {
$request = new ServerRequest(); $request = new ServerRequest();

View File

@ -5,8 +5,7 @@ namespace WellRESTed\Test\Message;
use WellRESTed\Message\Stream; use WellRESTed\Message\Stream;
/** /**
* @coversDefaultClass WellRESTed\Message\Stream * @covers WellRESTed\Message\Stream
* @uses WellRESTed\Message\Stream
* @group message * @group message
*/ */
class StreamTest extends \PHPUnit_Framework_TestCase class StreamTest extends \PHPUnit_Framework_TestCase
@ -27,9 +26,6 @@ class StreamTest extends \PHPUnit_Framework_TestCase
} }
} }
/**
* @covers ::__construct
*/
public function testCreatesInstanceWithStreamResource() public function testCreatesInstanceWithStreamResource()
{ {
$stream = new \WellRESTed\Message\Stream($this->resource); $stream = new \WellRESTed\Message\Stream($this->resource);
@ -43,7 +39,6 @@ class StreamTest extends \PHPUnit_Framework_TestCase
} }
/** /**
* @covers ::__construct
* @expectedException \InvalidArgumentException * @expectedException \InvalidArgumentException
* @dataProvider invalidResourceProvider * @dataProvider invalidResourceProvider
*/ */
@ -62,18 +57,12 @@ class StreamTest extends \PHPUnit_Framework_TestCase
]; ];
} }
/**
* @covers ::__toString
*/
public function testCastsToString() public function testCastsToString()
{ {
$stream = new \WellRESTed\Message\Stream($this->resource); $stream = new \WellRESTed\Message\Stream($this->resource);
$this->assertEquals($this->content, (string) $stream); $this->assertEquals($this->content, (string) $stream);
} }
/**
* @covers ::close
*/
public function testClosesHandle() public function testClosesHandle()
{ {
$stream = new Stream($this->resource); $stream = new Stream($this->resource);
@ -81,18 +70,12 @@ class StreamTest extends \PHPUnit_Framework_TestCase
$this->assertFalse(is_resource($this->resource)); $this->assertFalse(is_resource($this->resource));
} }
/**
* @covers ::detach
*/
public function testDetachReturnsHandle() public function testDetachReturnsHandle()
{ {
$stream = new Stream($this->resource); $stream = new Stream($this->resource);
$this->assertSame($this->resource, $stream->detach()); $this->assertSame($this->resource, $stream->detach());
} }
/**
* @covers ::detach
*/
public function testDetachUnsetsInstanceVariable() public function testDetachUnsetsInstanceVariable()
{ {
$stream = new \WellRESTed\Message\Stream($this->resource); $stream = new \WellRESTed\Message\Stream($this->resource);
@ -100,18 +83,12 @@ class StreamTest extends \PHPUnit_Framework_TestCase
$this->assertNull($stream->detach()); $this->assertNull($stream->detach());
} }
/**
* @covers ::getSize
*/
public function testReturnsSize() public function testReturnsSize()
{ {
$stream = new \WellRESTed\Message\Stream($this->resource); $stream = new \WellRESTed\Message\Stream($this->resource);
$this->assertEquals(strlen($this->content), $stream->getSize()); $this->assertEquals(strlen($this->content), $stream->getSize());
} }
/**
* @covers ::tell
*/
public function testTellReturnsHandlePosition() public function testTellReturnsHandlePosition()
{ {
$stream = new \WellRESTed\Message\Stream($this->resource); $stream = new \WellRESTed\Message\Stream($this->resource);
@ -119,9 +96,6 @@ class StreamTest extends \PHPUnit_Framework_TestCase
$this->assertEquals(10, $stream->tell()); $this->assertEquals(10, $stream->tell());
} }
/**
* @covers ::eof
*/
public function testReturnsOef() public function testReturnsOef()
{ {
$stream = new Stream($this->resource); $stream = new Stream($this->resource);
@ -130,9 +104,6 @@ class StreamTest extends \PHPUnit_Framework_TestCase
$this->assertTrue($stream->eof()); $this->assertTrue($stream->eof());
} }
/**
* @covers ::isSeekable
*/
public function testReadsSeekableStatusFromMetadata() public function testReadsSeekableStatusFromMetadata()
{ {
$stream = new \WellRESTed\Message\Stream($this->resource); $stream = new \WellRESTed\Message\Stream($this->resource);
@ -141,9 +112,6 @@ class StreamTest extends \PHPUnit_Framework_TestCase
$this->assertEquals($seekable, $stream->isSeekable()); $this->assertEquals($seekable, $stream->isSeekable());
} }
/**
* @covers ::seek
*/
public function testSeeksToPosition() public function testSeeksToPosition()
{ {
$stream = new \WellRESTed\Message\Stream($this->resource); $stream = new \WellRESTed\Message\Stream($this->resource);
@ -151,9 +119,6 @@ class StreamTest extends \PHPUnit_Framework_TestCase
$this->assertEquals(10, ftell($this->resource)); $this->assertEquals(10, ftell($this->resource));
} }
/**
* @covers ::rewind
*/
public function testRewindReturnsToBeginning() public function testRewindReturnsToBeginning()
{ {
$stream = new Stream($this->resource); $stream = new Stream($this->resource);
@ -162,9 +127,6 @@ class StreamTest extends \PHPUnit_Framework_TestCase
$this->assertEquals(0, ftell($this->resource)); $this->assertEquals(0, ftell($this->resource));
} }
/**
* @covers ::write
*/
public function testWritesToHandle() public function testWritesToHandle()
{ {
$message = "\nThis is a stream."; $message = "\nThis is a stream.";
@ -173,10 +135,7 @@ class StreamTest extends \PHPUnit_Framework_TestCase
$this->assertEquals($this->content . $message, (string) $stream); $this->assertEquals($this->content . $message, (string) $stream);
} }
/** /** @expectedException \RuntimeException */
* @covers ::write
* @expectedException \RuntimeException
*/
public function testThrowsExceptionOnErrorWriting() public function testThrowsExceptionOnErrorWriting()
{ {
$filename = tempnam(sys_get_temp_dir(), "php"); $filename = tempnam(sys_get_temp_dir(), "php");
@ -185,10 +144,7 @@ class StreamTest extends \PHPUnit_Framework_TestCase
$stream->write("Hello, world!"); $stream->write("Hello, world!");
} }
/** /** @expectedException \RuntimeException */
* @covers ::read
* @expectedException \RuntimeException
*/
public function testThrowsExceptionOnErrorReading() public function testThrowsExceptionOnErrorReading()
{ {
$filename = tempnam(sys_get_temp_dir(), "php"); $filename = tempnam(sys_get_temp_dir(), "php");
@ -197,9 +153,6 @@ class StreamTest extends \PHPUnit_Framework_TestCase
$stream->read(10); $stream->read(10);
} }
/**
* @covers ::read
*/
public function testReadsFromStream() public function testReadsFromStream()
{ {
$stream = new \WellRESTed\Message\Stream($this->resource); $stream = new \WellRESTed\Message\Stream($this->resource);
@ -208,10 +161,7 @@ class StreamTest extends \PHPUnit_Framework_TestCase
$this->assertEquals("world", $string); $this->assertEquals("world", $string);
} }
/** /** @expectedException \RuntimeException */
* @covers ::getContents
* @expectedException \RuntimeException
*/
public function testThrowsExceptionOnErrorReadingToEnd() public function testThrowsExceptionOnErrorReadingToEnd()
{ {
$filename = tempnam(sys_get_temp_dir(), "php"); $filename = tempnam(sys_get_temp_dir(), "php");
@ -220,9 +170,6 @@ class StreamTest extends \PHPUnit_Framework_TestCase
$stream->getContents(); $stream->getContents();
} }
/**
* @covers ::getContents
*/
public function testReadsToEnd() public function testReadsToEnd()
{ {
$stream = new Stream($this->resource); $stream = new Stream($this->resource);
@ -231,18 +178,12 @@ class StreamTest extends \PHPUnit_Framework_TestCase
$this->assertEquals("world!", $string); $this->assertEquals("world!", $string);
} }
/**
* @covers ::getMetadata
*/
public function testReturnsMetadataArray() public function testReturnsMetadataArray()
{ {
$stream = new \WellRESTed\Message\Stream($this->resource); $stream = new \WellRESTed\Message\Stream($this->resource);
$this->assertEquals(stream_get_meta_data($this->resource), $stream->getMetadata()); $this->assertEquals(stream_get_meta_data($this->resource), $stream->getMetadata());
} }
/**
* @covers ::getMetadata
*/
public function testReturnsMetadataItem() public function testReturnsMetadataItem()
{ {
$stream = new Stream($this->resource); $stream = new Stream($this->resource);
@ -250,10 +191,7 @@ class StreamTest extends \PHPUnit_Framework_TestCase
$this->assertEquals($metadata["mode"], $stream->getMetadata("mode")); $this->assertEquals($metadata["mode"], $stream->getMetadata("mode"));
} }
/** /** @dataProvider modeProvider */
* @covers ::isReadable
* @dataProvider modeProvider
*/
public function testReturnsIsReadableForReadableStreams($mode, $readable, $writeable) public function testReturnsIsReadableForReadableStreams($mode, $readable, $writeable)
{ {
$tmp = tempnam(sys_get_temp_dir(), "php"); $tmp = tempnam(sys_get_temp_dir(), "php");
@ -265,10 +203,7 @@ class StreamTest extends \PHPUnit_Framework_TestCase
$this->assertEquals($readable, $stream->isReadable()); $this->assertEquals($readable, $stream->isReadable());
} }
/** /** @dataProvider modeProvider */
* @covers ::isWritable
* @dataProvider modeProvider
*/
public function testReturnsIsWritableForWritableStreams($mode, $readable, $writeable) public function testReturnsIsWritableForWritableStreams($mode, $readable, $writeable)
{ {
$tmp = tempnam(sys_get_temp_dir(), "php"); $tmp = tempnam(sys_get_temp_dir(), "php");

View File

@ -9,10 +9,7 @@ use WellRESTed\Message\UploadedFileState;
require_once __DIR__ . "/../../../src/UploadedFileState.php"; require_once __DIR__ . "/../../../src/UploadedFileState.php";
/** /**
* @coversDefaultClass WellRESTed\Message\UploadedFile * @covers WellRESTed\Message\UploadedFile
* @uses WellRESTed\Message\UploadedFile
* @uses WellRESTed\Message\Stream
* @uses WellRESTed\Message\NullStream
* @group message * @group message
*/ */
class UploadedFileTest extends \PHPUnit_Framework_TestCase class UploadedFileTest extends \PHPUnit_Framework_TestCase
@ -42,20 +39,12 @@ class UploadedFileTest extends \PHPUnit_Framework_TestCase
// ------------------------------------------------------------------------ // ------------------------------------------------------------------------
// getStream // getStream
/**
* @covers ::__construct
* @covers ::getStream
*/
public function testGetStreamReturnsStreamInterface() public function testGetStreamReturnsStreamInterface()
{ {
$file = new UploadedFile("", "", 0, "", 0); $file = new UploadedFile("", "", 0, "", 0);
$this->assertInstanceOf('\Psr\Http\Message\StreamInterface', $file->getStream()); $this->assertInstanceOf('\Psr\Http\Message\StreamInterface', $file->getStream());
} }
/**
* @covers ::__construct
* @covers ::getStream
*/
public function testGetStreamReturnsStreamWrappingUploadedFile() public function testGetStreamReturnsStreamWrappingUploadedFile()
{ {
$content = "Hello, World!"; $content = "Hello, World!";
@ -65,21 +54,13 @@ class UploadedFileTest extends \PHPUnit_Framework_TestCase
$this->assertEquals($content, (string) $stream); $this->assertEquals($content, (string) $stream);
} }
/**
* @covers ::__construct
* @covers ::getStream
*/
public function testGetStreamReturnsEmptyStreamForNoFile() public function testGetStreamReturnsEmptyStreamForNoFile()
{ {
$file = new UploadedFile("", "", 0, "", 0); $file = new UploadedFile("", "", 0, "", 0);
$this->assertTrue($file->getStream()->eof()); $this->assertTrue($file->getStream()->eof());
} }
/** /** @expectedException \RuntimeException */
* @covers ::__construct
* @covers ::getStream
* @expectedException \RuntimeException
*/
public function testGetStreamThrowsExceptionAfterMoveTo() public function testGetStreamThrowsExceptionAfterMoveTo()
{ {
$content = "Hello, World!"; $content = "Hello, World!";
@ -89,11 +70,7 @@ class UploadedFileTest extends \PHPUnit_Framework_TestCase
$file->getStream(); $file->getStream();
} }
/** /** @expectedException \RuntimeException */
* @covers ::__construct
* @covers ::getStream
* @expectedException \RuntimeException
*/
public function testGetStreamThrowsExceptionForNonUploadedFile() public function testGetStreamThrowsExceptionForNonUploadedFile()
{ {
UploadedFileState::$php_sapi_name = "apache"; UploadedFileState::$php_sapi_name = "apache";
@ -105,9 +82,6 @@ class UploadedFileTest extends \PHPUnit_Framework_TestCase
// ------------------------------------------------------------------------ // ------------------------------------------------------------------------
// moveTo // moveTo
/**
* @covers ::moveTo
*/
public function testMoveToSapiRelocatesUploadedFileToDestiationIfExists() public function testMoveToSapiRelocatesUploadedFileToDestiationIfExists()
{ {
UploadedFileState::$php_sapi_name = "fpm-fcgi"; UploadedFileState::$php_sapi_name = "fpm-fcgi";
@ -122,9 +96,6 @@ class UploadedFileTest extends \PHPUnit_Framework_TestCase
$this->assertEquals($originalMd5, md5_file($this->movePath)); $this->assertEquals($originalMd5, md5_file($this->movePath));
} }
/**
* @covers ::moveTo
*/
public function testMoveToNonSapiRelocatesUploadedFileToDestiationIfExists() public function testMoveToNonSapiRelocatesUploadedFileToDestiationIfExists()
{ {
$content = "Hello, World!"; $content = "Hello, World!";
@ -137,11 +108,8 @@ class UploadedFileTest extends \PHPUnit_Framework_TestCase
$this->assertEquals($originalMd5, md5_file($this->movePath)); $this->assertEquals($originalMd5, md5_file($this->movePath));
} }
/** /** @expectedException \RuntimeException */
* @covers ::moveTo public function testMoveToThrowsExceptionOnSubsequentCall()
* @expectedException \RuntimeException
*/
public function testMoveToThrowsExcpetionOnSubsequentCall()
{ {
$content = "Hello, World!"; $content = "Hello, World!";
file_put_contents($this->tmpName, $content); file_put_contents($this->tmpName, $content);

View File

@ -5,8 +5,7 @@ namespace WellRESTed\Test\Message;
use WellRESTed\Message\Uri; use WellRESTed\Message\Uri;
/** /**
* @coversDefaultClass WellRESTed\Message\Uri * @covers WellRESTed\Message\Uri
* @uses WellRESTed\Message\Uri
* @group message * @group message
*/ */
class UriTest extends \PHPUnit_Framework_TestCase class UriTest extends \PHPUnit_Framework_TestCase
@ -14,21 +13,13 @@ class UriTest extends \PHPUnit_Framework_TestCase
// ------------------------------------------------------------------------ // ------------------------------------------------------------------------
// Scheme // Scheme
/**
* @covers ::getScheme
*/
public function testDefaultSchemeIsEmpty() public function testDefaultSchemeIsEmpty()
{ {
$uri = new Uri(); $uri = new Uri();
$this->assertSame("", $uri->getScheme()); $this->assertSame("", $uri->getScheme());
} }
/** /** @dataProvider schemeProvider */
* @covers ::withScheme
* @dataProvider schemeProvider
* @param string $expected The expected result of getScheme
* @param string $scheme The scheme to pass to withScheme
*/
public function testSetsSchemeCaseInsensitively($expected, $scheme) public function testSetsSchemeCaseInsensitively($expected, $scheme)
{ {
$uri = new Uri(); $uri = new Uri();
@ -48,10 +39,7 @@ class UriTest extends \PHPUnit_Framework_TestCase
]; ];
} }
/** /** @expectedException \InvalidArgumentException */
* @covers ::withScheme
* @expectedException \InvalidArgumentException
*/
public function testInvalidSchemeThrowsException() public function testInvalidSchemeThrowsException()
{ {
$uri = new Uri(); $uri = new Uri();
@ -61,9 +49,6 @@ class UriTest extends \PHPUnit_Framework_TestCase
// ------------------------------------------------------------------------ // ------------------------------------------------------------------------
// Authority // Authority
/**
* @covers ::getAuthority
*/
public function testDefaultAuthorityIsEmpty() public function testDefaultAuthorityIsEmpty()
{ {
$uri = new Uri(); $uri = new Uri();
@ -75,12 +60,7 @@ class UriTest extends \PHPUnit_Framework_TestCase
$this->assertTrue(true); $this->assertTrue(true);
} }
/** /** @dataProvider authorityProvider */
* @covers ::getAuthority
* @dataProvider authorityProvider
* @param string $expected
* @param array $components
*/
public function testConcatenatesAuthorityFromHostAndUserInfo($expected, $components) public function testConcatenatesAuthorityFromHostAndUserInfo($expected, $components)
{ {
$uri = new Uri(); $uri = new Uri();
@ -188,9 +168,6 @@ class UriTest extends \PHPUnit_Framework_TestCase
// ------------------------------------------------------------------------ // ------------------------------------------------------------------------
// User Info // User Info
/**
* @covers ::getUserInfo
*/
public function testDefaultUserInfoIsEmpty() public function testDefaultUserInfoIsEmpty()
{ {
$uri = new Uri(); $uri = new Uri();
@ -198,8 +175,6 @@ class UriTest extends \PHPUnit_Framework_TestCase
} }
/** /**
* @covers ::getUserInfo
* @covers ::withUserInfo
* @dataProvider userInfoProvider * @dataProvider userInfoProvider
* *
* @param string $expected The combined user:password value * @param string $expected The combined user:password value
@ -227,22 +202,13 @@ class UriTest extends \PHPUnit_Framework_TestCase
// ------------------------------------------------------------------------ // ------------------------------------------------------------------------
// Host // Host
/**
* @covers ::getHost
*/
public function testDefaultHostIsEmpty() public function testDefaultHostIsEmpty()
{ {
$uri = new Uri(); $uri = new Uri();
$this->assertSame("", $uri->getHost()); $this->assertSame("", $uri->getHost());
} }
/** /** @dataProvider hostProvider */
* @covers ::getHost
* @covers ::withHost
* @dataProvider hostProvider
* @param $expected
* @param $host
*/
public function testSetsHost($expected, $host) public function testSetsHost($expected, $host)
{ {
$uri = new Uri(); $uri = new Uri();
@ -261,10 +227,8 @@ class UriTest extends \PHPUnit_Framework_TestCase
} }
/** /**
* @covers ::withHost
* @expectedException \InvalidArgumentException * @expectedException \InvalidArgumentException
* @dataProvider invalidHostProvider * @dataProvider invalidHostProvider
* @param $host
*/ */
public function testInvalidHostThrowsException($host) public function testInvalidHostThrowsException($host)
{ {
@ -284,42 +248,25 @@ class UriTest extends \PHPUnit_Framework_TestCase
// ------------------------------------------------------------------------ // ------------------------------------------------------------------------
// Port // Port
/**
* @covers ::getPort
*/
public function testDefaultPortWithNoSchemeIsNull() public function testDefaultPortWithNoSchemeIsNull()
{ {
$uri = new Uri(); $uri = new Uri();
$this->assertNull($uri->getPort()); $this->assertNull($uri->getPort());
} }
/**
* @covers ::getPort
*/
public function testDefaultPortForHttpSchemeIs80() public function testDefaultPortForHttpSchemeIs80()
{ {
$uri = new Uri(); $uri = new Uri();
$this->assertSame(80, $uri->withScheme("http")->getPort()); $this->assertSame(80, $uri->withScheme("http")->getPort());
} }
/**
* @covers ::getPort
*/
public function testDefaultPortForHttpsSchemeIs443() public function testDefaultPortForHttpsSchemeIs443()
{ {
$uri = new Uri(); $uri = new Uri();
$this->assertSame(443, $uri->withScheme("https")->getPort()); $this->assertSame(443, $uri->withScheme("https")->getPort());
} }
/** /** @dataProvider portAndSchemeProvider */
* @covers ::getPort
* @covers ::withPort
* @dataProvider portAndSchemeProvider
*
* @param int|null $expectedPort
* @param string $scheme
* @param int|null $port
*/
public function testReturnsPortWithSchemeDefaults($expectedPort, $scheme, $port) public function testReturnsPortWithSchemeDefaults($expectedPort, $scheme, $port)
{ {
$uri = new Uri(); $uri = new Uri();
@ -340,10 +287,8 @@ class UriTest extends \PHPUnit_Framework_TestCase
} }
/** /**
* @covers ::withPort
* @expectedException \InvalidArgumentException * @expectedException \InvalidArgumentException
* @dataProvider invalidPortProvider * @dataProvider invalidPortProvider
* @param int $port
*/ */
public function testInvalidPortThrowsException($port) public function testInvalidPortThrowsException($port)
{ {
@ -364,23 +309,13 @@ class UriTest extends \PHPUnit_Framework_TestCase
// ------------------------------------------------------------------------ // ------------------------------------------------------------------------
// Path // Path
/**
* @covers ::getPath
*/
public function testDefaultPathIsEmpty() public function testDefaultPathIsEmpty()
{ {
$uri = new Uri(); $uri = new Uri();
$this->assertSame("", $uri->getPath()); $this->assertSame("", $uri->getPath());
} }
/** /** @dataProvider pathProvider */
* @covers ::getPath
* @covers ::withPath
* @covers ::percentEncode
* @dataProvider pathProvider
* @param $expected
* @param $path
*/
public function testSetsEncodedPath($expected, $path) public function testSetsEncodedPath($expected, $path)
{ {
$uri = new Uri(); $uri = new Uri();
@ -388,14 +323,7 @@ class UriTest extends \PHPUnit_Framework_TestCase
$this->assertSame($expected, $uri->getPath()); $this->assertSame($expected, $uri->getPath());
} }
/** /** @dataProvider pathProvider */
* @covers ::getPath
* @covers ::withPath
* @covers ::percentEncode
* @dataProvider pathProvider
* @param $expected
* @param $path
*/
public function testDoesNotDoubleEncodePath($expected, $path) public function testDoesNotDoubleEncodePath($expected, $path)
{ {
$uri = new Uri(); $uri = new Uri();
@ -420,23 +348,13 @@ class UriTest extends \PHPUnit_Framework_TestCase
// ------------------------------------------------------------------------ // ------------------------------------------------------------------------
// Query // Query
/**
* @covers ::getQuery
*/
public function testDefaultQueryIsEmpty() public function testDefaultQueryIsEmpty()
{ {
$uri = new Uri(); $uri = new Uri();
$this->assertSame("", $uri->getQuery()); $this->assertSame("", $uri->getQuery());
} }
/** /** @dataProvider queryProvider */
* @covers ::getQuery
* @covers ::withQuery
* @covers ::percentEncode
* @dataProvider queryProvider
* @param $expected
* @param $query
*/
public function testSetsEncodedQuery($expected, $query) public function testSetsEncodedQuery($expected, $query)
{ {
$uri = new Uri(); $uri = new Uri();
@ -444,14 +362,7 @@ class UriTest extends \PHPUnit_Framework_TestCase
$this->assertSame($expected, $uri->getQuery()); $this->assertSame($expected, $uri->getQuery());
} }
/** /** @dataProvider queryProvider */
* @covers ::getQuery
* @covers ::withQuery
* @covers ::percentEncode
* @dataProvider queryProvider
* @param $expected
* @param $query
*/
public function testDoesNotDoubleEncodeQuery($expected, $query) public function testDoesNotDoubleEncodeQuery($expected, $query)
{ {
$uri = new Uri(); $uri = new Uri();
@ -470,10 +381,8 @@ class UriTest extends \PHPUnit_Framework_TestCase
} }
/** /**
* @covers ::withPath
* @expectedException \InvalidArgumentException * @expectedException \InvalidArgumentException
* @dataProvider invalidPathProvider * @dataProvider invalidPathProvider
* @param $path
*/ */
public function testInvalidPathThrowsException($path) public function testInvalidPathThrowsException($path)
{ {
@ -493,23 +402,13 @@ class UriTest extends \PHPUnit_Framework_TestCase
// ------------------------------------------------------------------------ // ------------------------------------------------------------------------
// Fragment // Fragment
/**
* @covers ::getFragment
*/
public function testDefaultFragmentIsEmpty() public function testDefaultFragmentIsEmpty()
{ {
$uri = new Uri(); $uri = new Uri();
$this->assertSame("", $uri->getFragment()); $this->assertSame("", $uri->getFragment());
} }
/** /** @dataProvider fragmentProvider */
* @covers ::getFragment
* @covers ::withFragment
* @covers ::percentEncode
* @dataProvider fragmentProvider
* @param $expected
* @param $fragment
*/
public function testSetsEncodedFragment($expected, $fragment) public function testSetsEncodedFragment($expected, $fragment)
{ {
$uri = new Uri(); $uri = new Uri();
@ -517,14 +416,7 @@ class UriTest extends \PHPUnit_Framework_TestCase
$this->assertSame($expected, $uri->getFragment()); $this->assertSame($expected, $uri->getFragment());
} }
/** /** @dataProvider fragmentProvider */
* @covers ::getFragment
* @covers ::withFragment
* @covers ::percentEncode
* @dataProvider fragmentProvider
* @param $expected
* @param $fragment
*/
public function testDoesNotDoubleEncodeFragment($expected, $fragment) public function testDoesNotDoubleEncodeFragment($expected, $fragment)
{ {
$uri = new Uri(); $uri = new Uri();
@ -545,12 +437,7 @@ class UriTest extends \PHPUnit_Framework_TestCase
// ------------------------------------------------------------------------ // ------------------------------------------------------------------------
// Concatenation // Concatenation
/** /** @dataProvider componentProvider */
* @covers ::__toString
* @dataProvider componentProvider
* @param string $expected
* @param array $components
*/
public function testConcatenatesComponents($expected, $components) public function testConcatenatesComponents($expected, $components)
{ {
$uri = new Uri(); $uri = new Uri();
@ -653,11 +540,7 @@ class UriTest extends \PHPUnit_Framework_TestCase
]; ];
} }
/** /** @dataProvider stringUriProvider */
* @covers ::__construct()
* @covers ::__toString()
* @dataProvider stringUriProvider
*/
public function testUriCreatedFromStringNormalizesString($expected, $input) public function testUriCreatedFromStringNormalizesString($expected, $input)
{ {
$uri = new Uri($input); $uri = new Uri($input);