From 98014d8c59ffa7453ffb6abf97c463373f27319c Mon Sep 17 00:00:00 2001 From: PJ Dietz Date: Sun, 9 Aug 2020 14:30:19 -0400 Subject: [PATCH] Add type hints to Transmitter --- src/Transmission/Transmitter.php | 14 ++++++-------- src/Transmission/TransmitterInterface.php | 2 +- 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/src/Transmission/Transmitter.php b/src/Transmission/Transmitter.php index a23c31c..8bed7d5 100644 --- a/src/Transmission/Transmitter.php +++ b/src/Transmission/Transmitter.php @@ -27,7 +27,7 @@ class Transmitter implements TransmitterInterface public function transmit( ServerRequestInterface $request, ResponseInterface $response - ) { + ): void { // Prepare the response for output. $response = $this->prepareResponse($request, $response); @@ -48,10 +48,7 @@ class Transmitter implements TransmitterInterface } } - /** - * @param int $chunkSize - */ - public function setChunkSize($chunkSize) + public function setChunkSize(int $chunkSize): void { $this->chunkSize = $chunkSize; } @@ -59,7 +56,8 @@ class Transmitter implements TransmitterInterface protected function prepareResponse( ServerRequestInterface $request, ResponseInterface $response - ) { + ): ResponseInterface { + // Add a Content-length header to the response when all of these are true: // // - Response does not have a Content-length header @@ -77,7 +75,7 @@ class Transmitter implements TransmitterInterface return $response; } - private function getStatusLine(ResponseInterface $response) + private function getStatusLine(ResponseInterface $response): string { $protocol = $response->getProtocolVersion(); $statusCode = $response->getStatusCode(); @@ -89,7 +87,7 @@ class Transmitter implements TransmitterInterface } } - private function outputBody(StreamInterface $body) + private function outputBody(StreamInterface $body): void { if ($this->chunkSize > 0) { if ($body->isSeekable()) { diff --git a/src/Transmission/TransmitterInterface.php b/src/Transmission/TransmitterInterface.php index 4a639dd..9d6e947 100644 --- a/src/Transmission/TransmitterInterface.php +++ b/src/Transmission/TransmitterInterface.php @@ -18,5 +18,5 @@ interface TransmitterInterface * @param ServerRequestInterface $request * @param ResponseInterface $response Response to output */ - public function transmit(ServerRequestInterface $request, ResponseInterface $response); + public function transmit(ServerRequestInterface $request, ResponseInterface $response): void; }