Set Psalm error level to 3; fix possibly null reason phrase in Response

This commit is contained in:
PJ Dietz 2020-08-09 10:54:26 -04:00
parent 29cfa34f17
commit fe780e6b92
2 changed files with 4 additions and 7 deletions

View File

@ -1,6 +1,6 @@
<?xml version="1.0"?>
<psalm
errorLevel="4"
errorLevel="3"
resolveFromConfigFile="true"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xmlns="https://getpsalm.org/schema/config"

View File

@ -20,7 +20,7 @@ class Response extends Message implements ResponseInterface
{
/** @var string Text explanation of the HTTP Status Code. */
private $reasonPhrase;
/** @var int HTTP status code */
/** @var int HTTP status code */
private $statusCode;
/**
@ -103,7 +103,7 @@ class Response extends Message implements ResponseInterface
/**
* @param int $statusCode
* @return string|null
* @return string
*/
private function getDefaultReasonPhraseForStatusCode($statusCode)
{
@ -167,9 +167,6 @@ class Response extends Message implements ResponseInterface
510 => "Not Extended",
511 => "Network Authentication Required"
];
if (isset($reasonPhraseLookup[$statusCode])) {
return $reasonPhraseLookup[$statusCode];
}
return null;
return $reasonPhraseLookup[$statusCode] ?? '';
}
}