Clientbase
/
PhpSpreadsheet
mirror of https://github.com/basemaster/PhpSpreadsheet.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Minor refactoring work 

testColumnInRange method renamed to isColumnInRange
This commit is contained in:
aswinkumar863 2022-04-17 17:43:32 +05:30
parent 3a6ebc0ce6
commit 3c4a51acb5
No known key found for this signature in database
GPG Key ID: 8A69BFA6AEF8FA3E
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/PhpSpreadsheet/Worksheet/Table.php
View File

@ -272,7 +272,7 @@ class Table
* *
* @return int The column offset within the table range * @return int The column offset within the table range
*/ */
public function testColumnInRange($column) public function isColumnInRange($column)
{ {
if (empty($this->range)) { if (empty($this->range)) {
throw new PhpSpreadsheetException('No table range is defined.'); throw new PhpSpreadsheetException('No table range is defined.');
@ -296,7 +296,7 @@ class Table
*/ */
public function getColumnOffset($column) public function getColumnOffset($column)
{ {
return $this->testColumnInRange($column); return $this->isColumnInRange($column);
} }
/** /**
@ -308,7 +308,7 @@ class Table
*/ */
public function getColumn($column) public function getColumn($column)
{ {
$this->testColumnInRange($column); $this->isColumnInRange($column);
if (!isset($this->columns[$column])) { if (!isset($this->columns[$column])) {
$this->columns[$column] = new Table\Column($column, $this); $this->columns[$column] = new Table\Column($column, $this);
@ -349,7 +349,7 @@ class Table
} else { } else {
throw new PhpSpreadsheetException('Column is not within the table range.'); throw new PhpSpreadsheetException('Column is not within the table range.');
} }
$this->testColumnInRange($column); $this->isColumnInRange($column);
if (is_string($columnObjectOrString)) { if (is_string($columnObjectOrString)) {
$this->columns[$columnObjectOrString] = new Table\Column($columnObjectOrString, $this); $this->columns[$columnObjectOrString] = new Table\Column($columnObjectOrString, $this);
@ -371,7 +371,7 @@ class Table
*/ */
public function clearColumn($column) public function clearColumn($column)
{ {
$this->testColumnInRange($column); $this->isColumnInRange($column);
if (isset($this->columns[$column])) { if (isset($this->columns[$column])) {
unset($this->columns[$column]); unset($this->columns[$column]);

2
src/PhpSpreadsheet/Worksheet/Table/Column.php
View File

@ -89,7 +89,7 @@ class Column
// Uppercase coordinate // Uppercase coordinate
$column = strtoupper($column); $column = strtoupper($column);
if ($this->table !== null) { if ($this->table !== null) {
$this->table->testColumnInRange($column); $this->table->isColumnInRange($column);
} }
$this->columnIndex = $column; $this->columnIndex = $column;