Commit Graph

2439 Commits

Author SHA1 Message Date
MarkBaker bd0462bcfc Work on renaming method arguments for the Readers and Writers 2020-11-19 16:41:52 +01:00
MarkBaker 0acc8ff822 Merge branch 'master' into PHP8-Sane-Property-Names 2020-11-19 13:27:12 +01:00
Mark Baker 0ed5b800be
Resolve XSS Vulnerability in the HTML Writer (#1719)
Resolve XSS Vulnerability in the HTML Writer
2020-11-19 11:59:57 +01:00
MarkBaker 97f82c83de Type-hinting fixes 2020-11-16 21:45:05 +01:00
MarkBaker 29e0a8a6e8 Revert 2020-11-16 21:09:21 +01:00
MarkBaker 575ff5509c Cell row should be an int 2020-11-16 21:03:39 +01:00
MarkBaker 1626f5931b Scrutinizer fixes 2020-11-16 20:19:19 +01:00
MarkBaker d311603c6b Typecasting fixes 2020-11-16 19:48:32 +01:00
MarkBaker d6f2180fa0 Keep scrutinizer happy 2020-11-16 18:14:38 +01:00
MarkBaker 6bf24d8aac See if we can sort out scrutinizer's issue with the hash map 2020-11-16 17:34:44 +01:00
MarkBaker 3ad919575d See if we can sort out scrutinizer's issue with the hash map 2020-11-16 14:45:37 +01:00
MarkBaker 30482890c0 Merge branch 'master' into PHP8-Sane-Property-Names 2020-11-11 15:41:08 +01:00
oleibman 6fe653179f
Make DefinedNames Samples Consistent With Other Samples (#1707)
All other Samples write to temporary directory. DefinedNames samples
write to main directory, which (a) means they aren't stored with others,
and (b) they aren't ignored by git so look like changed files.
The tests are also simplified by requiring Header rather than Bootstrap,
making use of Helper.
2020-11-11 11:02:04 +01:00
MarkBaker 6e497a5fd6 Lets try some more modern annotations for index key/value typing 2020-11-07 20:14:32 +01:00
MarkBaker 34d15b80de Lets try some moew modern annotations for index key/value typing 2020-11-07 17:41:58 +01:00
MarkBaker 3f3a3174b5 Scrutinizer tweaks 2020-11-06 19:48:32 +01:00
MarkBaker d558e2ba99 Datatype fix 2020-11-05 21:20:33 +01:00
MarkBaker 86728cb214 Sane argument names for Styles 2020-11-05 20:04:35 +01:00
MarkBaker 317965078d Fix a couple of phpcs issues 2020-11-05 19:29:55 +01:00
MarkBaker cf6abbc10e Sane argument names in the various classes 2020-11-05 19:15:01 +01:00
MarkBaker b12cebe1f5 Sane argument names in the Chart classes 2020-11-03 20:43:42 +01:00
MarkBaker b5c2709002 Sane argument names in the Cell classes 2020-11-03 19:28:45 +01:00
MarkBaker 4ab629ff82 Sane argument names in the Reference Helper, Settings and Spreadsheet classes 2020-11-03 18:04:45 +01:00
MarkBaker af3918cac8 Sane argument names in the Reference Helper, Settings and Spreadsheet classes 2020-11-03 17:45:12 +01:00
MarkBaker 7e4248d67f Sane argument names in the IO Factory 2020-11-03 11:06:12 +01:00
MarkBaker 06f7d3c8bd Size validator for comment dimensions and margins 2020-11-02 23:48:57 +01:00
MarkBaker a16badbcc4 Size validator for comment dimensions and margins 2020-11-02 22:18:33 +01:00
MarkBaker 0502fd3e7f Size validator for comment dimensions and margins 2020-11-02 21:24:27 +01:00
MarkBaker 93fe84da71 Additional unit tests 2020-11-02 20:14:44 +01:00
MarkBaker 3a960d62a6 Remember return typehints for unit tests 2020-11-02 15:16:40 +01:00
MarkBaker 5e4288958c Additional unit tests for comments 2020-11-02 14:55:28 +01:00
MarkBaker b75551f0eb Adjustment for border style 2020-11-01 21:11:20 +01:00
MarkBaker f27e074756 Merge branch 'master' into PHP8-Sane-Property-Names
# Conflicts:
#	src/PhpSpreadsheet/Style/Alignment.php
#	src/PhpSpreadsheet/Style/Color.php
2020-11-01 14:42:30 +01:00
MarkBaker dc5a5670a0 Style fixes 2020-11-01 14:32:38 +01:00
MarkBaker 4107783e27 Additional unit tests for Style Color 2020-11-01 14:23:11 +01:00
MarkBaker 414c5217b8 Adjust colour validation calls 2020-11-01 12:12:28 +01:00
MarkBaker 613a0b96ae Adjust colour validation calls 2020-11-01 12:09:51 +01:00
CoryHrycko 0bf3986efa
Updating a misspelling of a function name. (#1695)
This will update the function name DCOUNTA from the misspelling of DCOUNT.
2020-11-01 12:05:04 +01:00
MarkBaker 212fc75e31 Remove redundant docblocks now that we've started typehinting 2020-10-30 13:02:15 +01:00
MarkBaker 6480243610 Remove redundant docblocks now that we've started typehinting 2020-10-30 12:50:30 +01:00
MarkBaker 6966c2fed3 Allow for null value when setting colour values 2020-10-30 11:30:28 +01:00
MarkBaker 7b750e3bf5 Fix default colour validation for supervisor 2020-10-30 11:15:37 +01:00
MarkBaker 5179781ab9 Starting work on ensuring that all methods are properly typehinted (arguments and returns) and that all argument names for public methods are meaningful (in readiness for PHP8 named arguments) 2020-10-30 10:48:54 +01:00
oleibman ae0cd46423
Add exportArray Method for Styles (#1580)
Issue #580 has gone stale since I started work on this.
Nevertheless, this implements an exportArray function as an
exact counterpart of applyFromArry.
I chose the name exportArray to avoid confusion with the existing
method getStyleArray, which does something completely different.

This change also increases coverage for all the Style classes to 100%,
with the exception of Style.php itself. There were several (unchanged)
places in Style.php where I did not have sufficient understanding of
what was supposed to be happening, so could not create tests.

All properties used by applyFromArray are exported by this method.
Note that conditional styles are not covered; this is consistent
with the fact that they are not covered by applyFromArray.

The method is implemented as a final public function in Style/Supervisor,
which calls abstract protected function exportArray1, which is implemented
in each of the subclasses, and which calls final protected
function exportArray2 in Style/Supervisor.
So exportArray is usable for any of the subclasses as well.

The new method is added to the documentation.
The existing documentation for applyFromArray was alphabetized to make
it easier to follow.
One property (Style quotePrefix) was added to the documentation.
Some Borders pseudo-properties (vertical, horizontal, and outline) were
documented as usable by applyFromArray,
but aren't actually supported - they were removed.
The documentation of the properties seemed to use setProperty and
getProperty fairly randomly - it now uses setProperty exclusively.

New constants were added for the textRotation "angles" used to create a
"stacked" cell. I felt that changing the readers and writers to use
these constants was beyond the scope of this change, but it is
on my to-do list.
2020-10-26 20:56:24 +01:00
Adrien Crivelli cc209d0b43
Refresh lock files 2020-10-19 09:31:34 +09:00
Jan-Simon Winkelmann 96e843ceee Prevent notice during accessing "cached magnification factor" offset
Sheet View Settings Block should be 8-14 bytes long in BIFF8 Excel 97 according
to the open office file format documentation. However access to byte 10 and 12 is
not possible when record data is malformed, so getUInt2d throws notice.
2020-10-12 20:53:30 +09:00
Mark Baker 92389c78eb
Ensure that the list of shared formulae is maintained while chunk-reading Xlsx Files (#1680)
* Ensure that the list of shared formulae is maintained while chunk-reading Xlsx files
2020-10-12 13:22:32 +02:00
Adrien Crivelli 1cda811017
Prepare for next version 2020-10-12 08:06:57 +09:00
Adrien Crivelli 6da3f30def
Remove coverage from Travis
Coverage data were not correctly uploaded for a long time now, and it
now is uploaded via GitHub Actions
2020-10-11 22:32:04 +09:00
Adrien Crivelli a8e8068b31
1.15.0 2020-10-11 22:20:59 +09:00