PhpSpreadsheet/tests/PhpSpreadsheetTests/Reader
oleibman 9512f54cca
Corrections for Xlsx Read Comments (#2329)
This change was suggested by issue #2316. There was a problem reading Xlsx comments which appeared with release 18.0 but which was already fixed in master. So no source change was needed to fix the issue, but I thought we should at least add the test case to our unit tests.

In developing that case, I discovered that, although comment text was read correctly, there was a problem with comment author. In fact, there were two problems. One was new, with the namespacing changes - as in several other cases, the namespaced attribute `authorId` needed some special handling. However, another problem was much older - the code was checking `!empty($comment['authorId'])`, eliminating consideration of authorId=0, and should instead have been checking `isset`. Both problems are now fixed, and tested.
2021-10-23 17:32:44 -07:00
..
Csv Permit CSV Delimiter to be Set to Null (#2288) 2021-09-15 12:40:03 -07:00
Gnumeric Gnumeric Reader - Distinguish Created and Modified Timestamps (#2133) 2021-05-31 10:24:37 +02:00
Html Html import dimension conversions (#2152) 2021-06-11 17:29:49 +02:00
Ods Tweaks to Input File Validation (#2217) 2021-07-24 20:44:04 -07:00
Security Reduce PHPStan error in tests 2021-04-12 11:10:23 +09:00
Slk Process Comments in Sylk File (#2277) 2021-08-26 11:56:13 -07:00
Utility When image source is a URL, store the URL for use during extraction. (#2072) 2021-06-24 10:50:44 +02:00
Xls fix #1114 issue (#2308) 2021-10-03 09:29:23 -07:00
Xlsx Corrections for Xlsx Read Comments (#2329) 2021-10-23 17:32:44 -07:00
Xml Reader XML Properties - Eliminate strtotime (#2134) 2021-05-31 11:04:07 +02:00